ShuriZma
/
mgba
mirror of https://github.com/mgba-emu/mgba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Core: Fix crash modifying hash table entry (fixes #1673)

This commit is contained in:
Vicki Pfau 2020-02-17 17:55:29 -08:00
parent 7611913d65
commit d14597f1ee
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES
View File

@ -13,6 +13,7 @@ Emulation fixes:
Other fixes: Other fixes:
- Core: Ensure ELF regions can be written before trying - Core: Ensure ELF regions can be written before trying
- Core: Fix ELF loading regression (fixes mgba.io/i/1669) - Core: Fix ELF loading regression (fixes mgba.io/i/1669)
- Core: Fix crash modifying hash table entry (fixes mgba.io/i/1673)
- Debugger: Don't skip undefined instructions when debugger attached - Debugger: Don't skip undefined instructions when debugger attached
- Qt: Force OpenGL paint engine creation thread (fixes mgba.io/i/1642) - Qt: Force OpenGL paint engine creation thread (fixes mgba.io/i/1642)
Misc: Misc:

2
src/util/table.c
View File

@ -187,7 +187,9 @@ void HashTableInsert(struct Table* table, const char* key, void* value) {
struct TableList* list; struct TableList* list;
TABLE_LOOKUP_START(HASH_TABLE_COMPARATOR, list, hash) { TABLE_LOOKUP_START(HASH_TABLE_COMPARATOR, list, hash) {
if (value != lookupResult->value) { if (value != lookupResult->value) {
if (table->deinitializer) {
table->deinitializer(lookupResult->value); table->deinitializer(lookupResult->value);
}
lookupResult->value = value; lookupResult->value = value;
} }
return; return;