diff --git a/CHANGES b/CHANGES index 237ee2892..d4ea6352f 100644 --- a/CHANGES +++ b/CHANGES @@ -8,6 +8,7 @@ Emulation fixes: - GBA Serialize: Fix audio serialization for desynced FIFOs - GBA Serialize: Fix audio DMA timing deserialization - GBA Video: Fix OAM not invalidating after reset (fixes mgba.io/i/1630) + - GBA Video: Latch scanline at end of Hblank (fixes mgba.io/i/1319) Other fixes: - Qt: Only dynamically reset video scale if a game is running - Qt: Fix race condition with proxied video events diff --git a/cinema/gba/bg/lady-sia/baseline_0000.png b/cinema/gba/bg/lady-sia/baseline_0000.png index 56454bbfa..282d9cf3b 100644 Binary files a/cinema/gba/bg/lady-sia/baseline_0000.png and b/cinema/gba/bg/lady-sia/baseline_0000.png differ diff --git a/cinema/gba/bg/lady-sia/baseline_0001.png b/cinema/gba/bg/lady-sia/baseline_0001.png index d1eb4323c..282d9cf3b 100644 Binary files a/cinema/gba/bg/lady-sia/baseline_0001.png and b/cinema/gba/bg/lady-sia/baseline_0001.png differ diff --git a/cinema/gba/bg/lady-sia/baseline_0002.png b/cinema/gba/bg/lady-sia/baseline_0002.png index 80f6dd2cb..14ffb7d46 100644 Binary files a/cinema/gba/bg/lady-sia/baseline_0002.png and b/cinema/gba/bg/lady-sia/baseline_0002.png differ diff --git a/cinema/gba/bg/lady-sia/baseline_0003.png b/cinema/gba/bg/lady-sia/baseline_0003.png index 30d9b4446..2e4d8ed37 100644 Binary files a/cinema/gba/bg/lady-sia/baseline_0003.png and b/cinema/gba/bg/lady-sia/baseline_0003.png differ diff --git a/cinema/gba/bg/lady-sia/baseline_0004.png b/cinema/gba/bg/lady-sia/baseline_0004.png new file mode 100644 index 000000000..6e0793103 Binary files /dev/null and b/cinema/gba/bg/lady-sia/baseline_0004.png differ diff --git a/cinema/gba/bg/lady-sia/baseline_0005.png b/cinema/gba/bg/lady-sia/baseline_0005.png new file mode 100644 index 000000000..b9320fb90 Binary files /dev/null and b/cinema/gba/bg/lady-sia/baseline_0005.png differ diff --git a/cinema/gba/bg/lady-sia/baseline_0006.png b/cinema/gba/bg/lady-sia/baseline_0006.png new file mode 100644 index 000000000..280f0152f Binary files /dev/null and b/cinema/gba/bg/lady-sia/baseline_0006.png differ diff --git a/cinema/gba/bg/lady-sia/baseline_0007.png b/cinema/gba/bg/lady-sia/baseline_0007.png new file mode 100644 index 000000000..b6355a2d5 Binary files /dev/null and b/cinema/gba/bg/lady-sia/baseline_0007.png differ diff --git a/cinema/gba/bg/lady-sia/test.mvl b/cinema/gba/bg/lady-sia/test.mvl index 214133dd2..ced00badf 100644 Binary files a/cinema/gba/bg/lady-sia/test.mvl and b/cinema/gba/bg/lady-sia/test.mvl differ diff --git a/cinema/gba/obj/unaligned-256-linear/baseline_0000.png b/cinema/gba/obj/unaligned-256-linear/baseline_0000.png index 4be2744f7..adf0534d0 100644 Binary files a/cinema/gba/obj/unaligned-256-linear/baseline_0000.png and b/cinema/gba/obj/unaligned-256-linear/baseline_0000.png differ diff --git a/cinema/gba/obj/unaligned-256-linear/baseline_0001.png b/cinema/gba/obj/unaligned-256-linear/baseline_0001.png index 4be2744f7..adf0534d0 100644 Binary files a/cinema/gba/obj/unaligned-256-linear/baseline_0001.png and b/cinema/gba/obj/unaligned-256-linear/baseline_0001.png differ diff --git a/cinema/gba/obj/unaligned-256-linear/baseline_0002.png b/cinema/gba/obj/unaligned-256-linear/baseline_0002.png index 5f20a6405..6b3cfab23 100644 Binary files a/cinema/gba/obj/unaligned-256-linear/baseline_0002.png and b/cinema/gba/obj/unaligned-256-linear/baseline_0002.png differ diff --git a/cinema/gba/obj/unaligned-256-linear/baseline_0003.png b/cinema/gba/obj/unaligned-256-linear/baseline_0003.png index 5f20a6405..6b3cfab23 100644 Binary files a/cinema/gba/obj/unaligned-256-linear/baseline_0003.png and b/cinema/gba/obj/unaligned-256-linear/baseline_0003.png differ diff --git a/src/gba/renderers/video-software.c b/src/gba/renderers/video-software.c index 666baa5e4..30758a548 100644 --- a/src/gba/renderers/video-software.c +++ b/src/gba/renderers/video-software.c @@ -701,16 +701,16 @@ static void GBAVideoSoftwareRendererFinishFrame(struct GBAVideoRenderer* rendere softwareRenderer->bg[3].sy = softwareRenderer->bg[3].refy; if (softwareRenderer->bg[0].enabled > 0) { - softwareRenderer->bg[0].enabled = 4; + softwareRenderer->bg[0].enabled = 3; } if (softwareRenderer->bg[1].enabled > 0) { - softwareRenderer->bg[1].enabled = 4; + softwareRenderer->bg[1].enabled = 3; } if (softwareRenderer->bg[2].enabled > 0) { - softwareRenderer->bg[2].enabled = 4; + softwareRenderer->bg[2].enabled = 3; } if (softwareRenderer->bg[3].enabled > 0) { - softwareRenderer->bg[3].enabled = 4; + softwareRenderer->bg[3].enabled = 3; } } @@ -737,7 +737,7 @@ static void _enableBg(struct GBAVideoSoftwareRenderer* renderer, int bg, bool ac } else if (!wasActive && active) { if (renderer->nextY == 0 || GBARegisterDISPCNTGetMode(renderer->dispcnt) > 2) { // TODO: Investigate in more depth how switching background works in different modes - renderer->bg[bg].enabled = 4; + renderer->bg[bg].enabled = 3; } else { renderer->bg[bg].enabled = 1; } @@ -811,7 +811,7 @@ static void GBAVideoSoftwareRendererWriteBLDCNT(struct GBAVideoSoftwareRenderer* #define TEST_LAYER_ENABLED(X) \ !renderer->d.disableBG[X] && \ - (renderer->bg[X].enabled == 4 && \ + (renderer->bg[X].enabled == 3 && \ (GBAWindowControlIsBg ## X ## Enable(renderer->currentWindow.packed) || \ (GBARegisterDISPCNTIsObjwinEnable(renderer->dispcnt) && GBAWindowControlIsBg ## X ## Enable (renderer->objwin.packed))) && \ renderer->bg[X].priority == priority) @@ -919,19 +919,19 @@ static void _drawScanline(struct GBAVideoSoftwareRenderer* renderer, int y) { renderer->bg[3].sy += renderer->bg[3].dmy; } - if (renderer->bg[0].enabled > 0 && renderer->bg[0].enabled < 4) { + if (renderer->bg[0].enabled > 0 && renderer->bg[0].enabled < 3) { ++renderer->bg[0].enabled; DIRTY_SCANLINE(renderer, y); } - if (renderer->bg[1].enabled > 0 && renderer->bg[1].enabled < 4) { + if (renderer->bg[1].enabled > 0 && renderer->bg[1].enabled < 3) { ++renderer->bg[1].enabled; DIRTY_SCANLINE(renderer, y); } - if (renderer->bg[2].enabled > 0 && renderer->bg[2].enabled < 4) { + if (renderer->bg[2].enabled > 0 && renderer->bg[2].enabled < 3) { ++renderer->bg[2].enabled; DIRTY_SCANLINE(renderer, y); } - if (renderer->bg[3].enabled > 0 && renderer->bg[3].enabled < 4) { + if (renderer->bg[3].enabled > 0 && renderer->bg[3].enabled < 3) { ++renderer->bg[3].enabled; DIRTY_SCANLINE(renderer, y); } diff --git a/src/gba/video.c b/src/gba/video.c index a05d6a7f0..b5b2dbb90 100644 --- a/src/gba/video.c +++ b/src/gba/video.c @@ -129,6 +129,10 @@ void _startHdraw(struct mTiming* timing, void* context, uint32_t cyclesLate) { } video->p->memory.io[REG_VCOUNT >> 1] = video->vcount; + if (video->vcount < GBA_VIDEO_VERTICAL_PIXELS && video->frameskipCounter <= 0) { + video->renderer->drawScanline(video->renderer, video->vcount); + } + if (video->vcount == GBARegisterDISPSTATGetVcountSetting(dispstat)) { dispstat = GBARegisterDISPSTATFillVcounter(dispstat); if (GBARegisterDISPSTATIsVcounterIRQ(dispstat)) { @@ -176,9 +180,6 @@ void _startHblank(struct mTiming* timing, void* context, uint32_t cyclesLate) { // Begin Hblank dispstat = GBARegisterDISPSTATFillInHblank(dispstat); - if (video->vcount < GBA_VIDEO_VERTICAL_PIXELS && video->frameskipCounter <= 0) { - video->renderer->drawScanline(video->renderer, video->vcount); - } if (video->vcount < GBA_VIDEO_VERTICAL_PIXELS) { GBADMARunHblank(video->p, -cyclesLate);