ShuriZma
/
mgba
mirror of https://github.com/mgba-emu/mgba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GBA BIOS: BitUnPack improvements

This commit is contained in:
Vicki Pfau 2019-01-07 22:15:23 -08:00
parent dfc9baa438
commit c292aa16e8
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES
View File

@ -64,6 +64,7 @@ Bugfixes:
- GB Audio: Fix channel 1, 2 and 4 reset timing - GB Audio: Fix channel 1, 2 and 4 reset timing
- Util: Fix wrapping edge cases in RingFIFO - Util: Fix wrapping edge cases in RingFIFO
- GBA Hardware: Fix RTC handshake transition (fixes mgba.io/i/1134) - GBA Hardware: Fix RTC handshake transition (fixes mgba.io/i/1134)
- GBA BIOS: Fix BitUnPack narrowing
Misc: Misc:
- GBA Timer: Use global cycles for timers - GBA Timer: Use global cycles for timers
- GBA: Extend oddly-sized ROMs to full address space (fixes mgba.io/i/722) - GBA: Extend oddly-sized ROMs to full address space (fixes mgba.io/i/722)

3
src/gba/bios.c
View File

@ -820,7 +820,6 @@ static void _unBitPack(struct GBA* gba) {
in >>= sourceWidth; in >>= sourceWidth;
if (scaled || bias & 0x80000000) { if (scaled || bias & 0x80000000) {
scaled += bias & 0x7FFFFFFF; scaled += bias & 0x7FFFFFFF;
scaled &= (1 << destWidth) - 1;
} }
bitsRemaining -= sourceWidth; bitsRemaining -= sourceWidth;
out |= scaled << bitsEaten; out |= scaled << bitsEaten;
@ -832,4 +831,6 @@ static void _unBitPack(struct GBA* gba) {
dest += 4; dest += 4;
} }
} }
cpu->gprs[0] = source;
cpu->gprs[1] = dest;
} }