GBA Video: Invalidate map cache when modifying BGCNT (fixes #1846)

2020-08-08 18:22:09 -07:00 · 2020-08-08 18:22:09 -07:00 · c2893d641e
parent defaeb0d80
commit c2893d641e
19 changed files with 2 additions and 0 deletions
--- a/1
+++ b/1
@ -23,6 +23,7 @@ Emulation fixes:
 - GBA SIO: Fix Normal mode being totally broken (fixes mgba.io/i/1800)
 - GBA Video: Latch scanline at end of Hblank (fixes mgba.io/i/1319)
 - GBA Video: Fix Hblank timing
+ - GBA Video: Invalidate map cache when modifying BGCNT (fixes mgba.io/i/1846)
 - SM83: Emulate HALT bug
 Other fixes:
 - 3DS: Redo video sync to be more precise
--- a/cinema/gba/bg/ff6-midframe-update/baseline_0000.png
+++ b/cinema/gba/bg/ff6-midframe-update/baseline_0000.png
--- a/cinema/gba/bg/ff6-midframe-update/baseline_0001.png
+++ b/cinema/gba/bg/ff6-midframe-update/baseline_0001.png
--- a/cinema/gba/bg/ff6-midframe-update/baseline_0002.png
+++ b/cinema/gba/bg/ff6-midframe-update/baseline_0002.png
--- a/cinema/gba/bg/ff6-midframe-update/baseline_0003.png
+++ b/cinema/gba/bg/ff6-midframe-update/baseline_0003.png
--- a/cinema/gba/bg/ff6-midframe-update/baseline_0004.png
+++ b/cinema/gba/bg/ff6-midframe-update/baseline_0004.png
--- a/cinema/gba/bg/ff6-midframe-update/baseline_0005.png
+++ b/cinema/gba/bg/ff6-midframe-update/baseline_0005.png
--- a/cinema/gba/bg/ff6-midframe-update/baseline_0006.png
+++ b/cinema/gba/bg/ff6-midframe-update/baseline_0006.png
--- a/cinema/gba/bg/ff6-midframe-update/baseline_0007.png
+++ b/cinema/gba/bg/ff6-midframe-update/baseline_0007.png
--- a/cinema/gba/bg/ff6-midframe-update/baseline_0008.png
+++ b/cinema/gba/bg/ff6-midframe-update/baseline_0008.png
--- a/cinema/gba/bg/ff6-midframe-update/baseline_0009.png
+++ b/cinema/gba/bg/ff6-midframe-update/baseline_0009.png
--- a/cinema/gba/bg/ff6-midframe-update/baseline_0010.png
+++ b/cinema/gba/bg/ff6-midframe-update/baseline_0010.png
--- a/cinema/gba/bg/ff6-midframe-update/baseline_0011.png
+++ b/cinema/gba/bg/ff6-midframe-update/baseline_0011.png
--- a/cinema/gba/bg/ff6-midframe-update/baseline_0012.png
+++ b/cinema/gba/bg/ff6-midframe-update/baseline_0012.png
--- a/cinema/gba/bg/ff6-midframe-update/baseline_0013.png
+++ b/cinema/gba/bg/ff6-midframe-update/baseline_0013.png
--- a/cinema/gba/bg/ff6-midframe-update/baseline_0014.png
+++ b/cinema/gba/bg/ff6-midframe-update/baseline_0014.png
--- a/cinema/gba/bg/ff6-midframe-update/baseline_0015.png
+++ b/cinema/gba/bg/ff6-midframe-update/baseline_0015.png
--- a/cinema/gba/bg/ff6-midframe-update/test.mvl
+++ b/cinema/gba/bg/ff6-midframe-update/test.mvl
--- a/src/gba/renderers/video-software.c
+++ b/src/gba/renderers/video-software.c
@ -760,6 +760,7 @@ static void GBAVideoSoftwareRendererWriteBGCNT(struct GBAVideoSoftwareRenderer*
 	bg->screenBase = GBARegisterBGCNTGetScreenBase(value) << 11;
 	bg->overflow = GBARegisterBGCNTGetOverflow(value);
 	bg->size = GBARegisterBGCNTGetSize(value);
+	bg->yCache = -1;
 }

 static void GBAVideoSoftwareRendererWriteBGX_LO(struct GBAVideoSoftwareBackground* bg, uint16_t value) {