From ae3a5988d08026083af64e97f348e9b0bd62d222 Mon Sep 17 00:00:00 2001 From: Vicki Pfau Date: Fri, 7 Mar 2025 23:03:43 -0800 Subject: [PATCH] Qt: Placate Coverity a bit --- src/platform/qt/SaveConverter.cpp | 6 +++--- src/platform/qt/Window.cpp | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/platform/qt/SaveConverter.cpp b/src/platform/qt/SaveConverter.cpp index 205a7563d..3383e006e 100644 --- a/src/platform/qt/SaveConverter.cpp +++ b/src/platform/qt/SaveConverter.cpp @@ -395,7 +395,7 @@ SaveConverter::AnnotatedSave::AnnotatedSave(mPlatform platform, std::shared_ptr< : container(container) , platform(platform) , size(vf->size()) - , backing(vf) + , backing(std::move(vf)) , endianness(endianness) { } @@ -405,7 +405,7 @@ SaveConverter::AnnotatedSave::AnnotatedSave(GBASavedataType type, std::shared_pt : container(container) , platform(mPLATFORM_GBA) , size(vf->size()) - , backing(vf) + , backing(std::move(vf)) , endianness(endianness) , gba({type}) { @@ -417,7 +417,7 @@ SaveConverter::AnnotatedSave::AnnotatedSave(GBMemoryBankControllerType type, std : container(container) , platform(mPLATFORM_GB) , size(vf->size()) - , backing(vf) + , backing(std::move(vf)) , endianness(endianness) , gb({type}) { diff --git a/src/platform/qt/Window.cpp b/src/platform/qt/Window.cpp index a224c3ba4..97d77ed84 100644 --- a/src/platform/qt/Window.cpp +++ b/src/platform/qt/Window.cpp @@ -1101,7 +1101,7 @@ void Window::reloadDisplayDriver() { if (!proxy) { proxy = std::make_shared(); } - m_display->setVideoProxy(proxy); + m_display->setVideoProxy(std::move(proxy)); #ifdef ENABLE_SCRIPTING if (m_scripting) { m_scripting->setVideoBackend(m_display->videoBackend());