From a566c9ab668a53c48df55f3ba8cd82605029c168 Mon Sep 17 00:00:00 2001 From: Vicki Pfau Date: Wed, 8 Jan 2020 19:58:40 -0800 Subject: [PATCH] Debugger: Fix tracing skipping instructions (fixes #1614) --- CHANGES | 1 + src/debugger/cli-debugger.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGES b/CHANGES index c7462b175..f70a6c113 100644 --- a/CHANGES +++ b/CHANGES @@ -99,6 +99,7 @@ Other fixes: - 3DS: Fix screen darkening (fixes mgba.io/i/1562) - Core: Fix uninitialized memory issues with graphics caches - Core: Return null for out of bounds cached tile VRAM querying + - Debugger: Fix tracing skipping instructions (fixes mgba.io/i/1614) - OpenGL: Only invalidate texture if dimensions change (fixes mgba.io/i/1612) - Qt: Fix fast forward mute being reset (fixes mgba.io/i/1574) - Qt: Fix scrollbar arrows in memory view (fixes mgba.io/i/1558) diff --git a/src/debugger/cli-debugger.c b/src/debugger/cli-debugger.c index 35b5dd3a7..08054935a 100644 --- a/src/debugger/cli-debugger.c +++ b/src/debugger/cli-debugger.c @@ -709,7 +709,6 @@ static void _trace(struct CLIDebugger* debugger, struct CLIDebugVector* dv) { static bool _doTrace(struct CLIDebugger* debugger) { char trace[1024]; trace[sizeof(trace) - 1] = '\0'; - debugger->d.core->step(debugger->d.core); size_t traceSize = sizeof(trace) - 2; debugger->d.platform->trace(debugger->d.platform, trace, &traceSize); if (traceSize + 1 <= sizeof(trace)) {