ShuriZma
/
mgba
mirror of https://github.com/mgba-emu/mgba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DS: Fix freeing memory for partial BIOS on load failure

This commit is contained in:
Vicki Pfau 2020-07-21 19:17:38 -07:00
parent 1c0aa6c358
commit 92c1087adf
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES
View File

@ -16,6 +16,7 @@ Bugfixes:
- GBA Video: Fix regression adjusting brightness of backdrop - GBA Video: Fix regression adjusting brightness of backdrop
- DS GX: Properly reject invalid commands - DS GX: Properly reject invalid commands
- DS: Fix leaking BIOS and firmware filehandles - DS: Fix leaking BIOS and firmware filehandles
- DS: Fix freeing memory for partial BIOS on load failure
Misc: Misc:
- DS GX: Clean up and unify texture mapping - DS GX: Clean up and unify texture mapping
- DS Core: Add symbol loading - DS Core: Add symbol loading

6
src/ds/ds.c
View File

@ -597,7 +597,11 @@ bool DSLoadBIOS(struct DS* ds, struct VFile* vf) {
mLOG(DS, INFO, "Official DS ARM9 BIOS detected"); mLOG(DS, INFO, "Official DS ARM9 BIOS detected");
} else { } else {
mLOG(DS, WARN, "BIOS checksum incorrect"); mLOG(DS, WARN, "BIOS checksum incorrect");
vf->unmap(vf, data, size); if (size == 0x1000) {
free(data);
} else {
vf->unmap(vf, data, size);
}
return false; return false;
} }
return true; return true;