From 7ec56763f9d6c68f8d3f7f16a9e34fffcd765492 Mon Sep 17 00:00:00 2001 From: Vicki Pfau Date: Sun, 24 Nov 2024 17:55:04 -0800 Subject: [PATCH] Qt: Fix installer updates if a version number is in the filename (fixes #3109) --- CHANGES | 1 + src/platform/qt/GBAApp.cpp | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGES b/CHANGES index e432bee67..f0a3d785f 100644 --- a/CHANGES +++ b/CHANGES @@ -39,6 +39,7 @@ Other fixes: - Qt: Fix crash when applying changes to GB I/O registers in I/O view - Qt: Fix LCDC background priority/enable bit being mis-mapped in I/O view - Qt: Fix saving named states breaking when screenshot states disabled (fixes mgba.io/i/3320) + - Qt: Fix installer updates if a version number is in the filename (fixes mgba.io/i/3109) - Updater: Fix updating appimage across filesystems Misc: - Core: Handle relative paths for saves, screenshots, etc consistently (fixes mgba.io/i/2826) diff --git a/src/platform/qt/GBAApp.cpp b/src/platform/qt/GBAApp.cpp index fdc710c0c..90fc89170 100644 --- a/src/platform/qt/GBAApp.cpp +++ b/src/platform/qt/GBAApp.cpp @@ -370,7 +370,7 @@ void GBAApp::cleanupAfterUpdate() { void GBAApp::restartForUpdate() { QFileInfo updaterPath(m_updater.updateInfo().url.path()); QDir configDir(ConfigController::configDir()); - if (updaterPath.completeSuffix() == "exe") { + if (updaterPath.suffix() == "exe") { m_invokeOnExit = configDir.filePath(QLatin1String("update.exe")); } else { QFile updater(":/updater");