ShuriZma
/
mgba
mirror of https://github.com/mgba-emu/mgba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GB, GBA Video: Fix integer overflow

This commit is contained in:
Vicki Pfau 2017-04-18 04:02:44 -07:00
parent caf59d726f
commit 716a245397
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/gb/renderers/proxy.c
View File

@ -130,7 +130,7 @@ static bool _parsePacket(struct mVideoLogger* logger, const struct mVideoLoggerD
} }
break; break;
case DIRTY_VRAM: case DIRTY_VRAM:
if (item->address + 0x1000 <= GB_SIZE_VRAM) { if (item->address <= GB_SIZE_VRAM - 0x1000) {
logger->readData(logger, &logger->vram[item->address >> 1], 0x1000, true); logger->readData(logger, &logger->vram[item->address >> 1], 0x1000, true);
proxyRenderer->backend->writeVRAM(proxyRenderer->backend, item->address); proxyRenderer->backend->writeVRAM(proxyRenderer->backend, item->address);
} }

2
src/gba/renderers/proxy.c
View File

@ -142,7 +142,7 @@ static bool _parsePacket(struct mVideoLogger* logger, const struct mVideoLoggerD
} }
break; break;
case DIRTY_VRAM: case DIRTY_VRAM:
if (item->address + 0x1000 <= SIZE_VRAM) { if (item->address <= SIZE_VRAM - 0x1000) {
logger->readData(logger, &logger->vram[item->address >> 1], 0x1000, true); logger->readData(logger, &logger->vram[item->address >> 1], 0x1000, true);
proxyRenderer->backend->writeVRAM(proxyRenderer->backend, item->address); proxyRenderer->backend->writeVRAM(proxyRenderer->backend, item->address);
} }