ShuriZma
/
mgba
mirror of https://github.com/mgba-emu/mgba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GBA BIOS: Fix HuffUnComp boundary conditions 

Conflicts:
	CHANGES
	src/gba/gba-bios.c
This commit is contained in:
Jeffrey Pfau 2015-01-15 01:35:02 -08:00
parent 3ec8afc507
commit 6b250448d5
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES
View File

@ -32,6 +32,7 @@ Bugfixes:
- GBA BIOS: Fix GetBiosChecksum to return the value of a real GBA, regardless of used BIOS
- GBA Memory: Properly bounds-check VRAM accesses
- GBA Memory: Fix initial DMA state
- GBA BIOS: Fix HuffUnComp boundary conditions
Misc:
- Qt: Disable sync to video by default
- GBA: Exit cleanly on FATAL if the port supports it

6
src/gba/gba-bios.c
View File

@ -322,8 +322,6 @@ static void _unHuffman(struct GBA* gba, uint32_t source, uint32_t dest) {
GBALog(gba, GBA_LOG_STUB, "Unimplemented unaligned Huffman");
return;
}
int padding = (4 - remaining) & 0x3;
remaining &= 0xFFFFFFFC;
// We assume the signature byte (0x20) is correct
int treesize = (cpu->memory.loadU8(cpu, source + 4, 0) << 1) + 1;
int block = 0;
@ -373,10 +371,6 @@ static void _unHuffman(struct GBA* gba, uint32_t source, uint32_t dest) {
block = 0;
}
}
}
if (padding) {
cpu->memory.store32(cpu, dPointer, block, 0);
}
}