GBA: Reject incorrectly sized BIOSes

This commit is contained in:
Vicki Pfau 2020-02-20 18:09:45 -08:00
parent 8821024705
commit 6055c4e8db
2 changed files with 5 additions and 0 deletions

View File

@ -15,6 +15,7 @@ Other fixes:
- Core: Ensure ELF regions can be written before trying
- Core: Fix ELF loading regression (fixes mgba.io/i/1669)
- Core: Fix crash modifying hash table entry (fixes mgba.io/i/1673)
- GBA: Reject incorrectly sized BIOSes
- Debugger: Don't skip undefined instructions when debugger attached
- Qt: Force OpenGL paint engine creation thread (fixes mgba.io/i/1642)
Misc:

View File

@ -441,6 +441,10 @@ void GBAYankROM(struct GBA* gba) {
void GBALoadBIOS(struct GBA* gba, struct VFile* vf) {
gba->biosVf = vf;
if (vf->size(vf) != SIZE_BIOS) {
mLOG(GBA, WARN, "Incorrect BIOS size");
return;
}
uint32_t* bios = vf->map(vf, SIZE_BIOS, MAP_READ);
if (!bios) {
mLOG(GBA, WARN, "Couldn't map BIOS");