ShuriZma
/
mgba
mirror of https://github.com/mgba-emu/mgba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Mask away unused GPIO bits 

Unused GPIO bits are not writable and always return 0. This is documented on gbatek and I've confirmed this is the correct behavior on my own Emerald cartridge.
This commit is contained in:
CasualPokePlayer 2025-03-31 18:41:03 -07:00 committed by Vicki Pfau
parent 93d248859f
commit 4bca59daa5
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/gba/cart/gpio.c
View File

@ -78,15 +78,15 @@ void GBAHardwareGPIOWrite(struct GBACartridgeHardware* hw, uint32_t address, uin
hw->pinState &= ~hw->direction;
hw->pinState |= value & hw->direction;
} else {
hw->pinState = value;
hw->pinState = value & 0xF;
}
_readPins(hw);
break;
case GPIO_REG_DIRECTION:
hw->direction = value;
hw->direction = value & 0xF;
break;
case GPIO_REG_CONTROL:
hw->readWrite = value;
hw->readWrite = value & 0x1;
break;
default:
mLOG(GBA_HW, WARN, "Invalid GPIO address");
@ -514,6 +514,8 @@ void GBAHardwareDeserialize(struct GBACartridgeHardware* hw, const struct GBASer
hw->readWrite = GBASerializedHWFlags1GetReadWrite(flags1);
LOAD_16(hw->pinState, 0, &state->hw.pinState);
LOAD_16(hw->direction, 0, &state->hw.pinDirection);
hw->pinState &= 0xF;
hw->direction &= 0xF;
hw->devices = state->hw.devices;
if ((hw->devices & HW_GPIO) && hw->gpioBase) {