GBA: Reject incorrectly sized BIOSes

This commit is contained in:
Vicki Pfau 2020-02-20 18:09:45 -08:00
parent 94ac311829
commit 45e0eb7013
2 changed files with 5 additions and 0 deletions

View File

@ -6,6 +6,7 @@ Emulation fixes:
Other fixes:
- Core: Fix ELF loading regression (fixes mgba.io/i/1669)
- Core: Fix crash modifying hash table entry (fixes mgba.io/i/1673)
- GBA: Reject incorrectly sized BIOSes
- Qt: Fix OpenGL 2.1 support (fixes mgba.io/i/1678)
Misc:
- Qt: Disable Replace ROM option when no game loaded

View File

@ -445,6 +445,10 @@ void GBAYankROM(struct GBA* gba) {
void GBALoadBIOS(struct GBA* gba, struct VFile* vf) {
gba->biosVf = vf;
if (vf->size(vf) != SIZE_BIOS) {
mLOG(GBA, WARN, "Incorrect BIOS size");
return;
}
uint32_t* bios = vf->map(vf, SIZE_BIOS, MAP_READ);
if (!bios) {
mLOG(GBA, WARN, "Couldn't map BIOS");