ShuriZma
/
mgba
mirror of https://github.com/mgba-emu/mgba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GBA Memory: Remove incorrect hack

This commit is contained in:
Jeffrey Pfau 2015-05-24 22:50:21 -07:00
parent c8a58dbc32
commit 3974042259
2 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES
View File

@ -22,7 +22,6 @@ Features:
Bugfixes: Bugfixes:
- ARM7: Fix SWI and IRQ timings - ARM7: Fix SWI and IRQ timings
- GBA Audio: Force audio FIFOs to 32-bit - GBA Audio: Force audio FIFOs to 32-bit
- GBA Memory: Ensure changing the timing of a DMA reschedules it
- GBA Memory: Improve Thumb open bus behavior - GBA Memory: Improve Thumb open bus behavior
- VFS: Fix resource leaks if some allocations fail - VFS: Fix resource leaks if some allocations fail
- Video: Fix an issue with very long filenames - Video: Fix an issue with very long filenames

6
src/gba/memory.c
View File

@ -1313,12 +1313,6 @@ uint16_t GBAMemoryWriteDMACNT_HI(struct GBA* gba, int dma, uint16_t control) {
struct GBAMemory* memory = &gba->memory; struct GBAMemory* memory = &gba->memory;
struct GBADMA* currentDma = &memory->dma[dma]; struct GBADMA* currentDma = &memory->dma[dma];
int wasEnabled = GBADMARegisterIsEnable(currentDma->reg); int wasEnabled = GBADMARegisterIsEnable(currentDma->reg);
int oldTiming = GBADMARegisterGetTiming(currentDma->reg);
int newTiming = GBADMARegisterGetTiming(control);
// This is probably a huge hack...verify what this does on hardware
if (oldTiming && oldTiming != DMA_TIMING_CUSTOM && oldTiming != newTiming) {
wasEnabled = false;
}
currentDma->reg = control; currentDma->reg = control;
if (GBADMARegisterIsDRQ(currentDma->reg)) { if (GBADMARegisterIsDRQ(currentDma->reg)) {