ShuriZma
/
mgba
mirror of https://github.com/mgba-emu/mgba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Core: Fix memory leak loading ELF files

This commit is contained in:
Vicki Pfau 2020-08-17 01:00:36 -07:00
parent f4522c3942
commit 343812e9e6
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES
View File

@ -39,6 +39,7 @@ Other fixes:
- All: Improve export headers (fixes mgba.io/i/1738) - All: Improve export headers (fixes mgba.io/i/1738)
- Core: Ensure ELF regions can be written before trying - Core: Ensure ELF regions can be written before trying
- Core: Fix reported ROM size when a fixed buffer size is used - Core: Fix reported ROM size when a fixed buffer size is used
- Core: Fix memory leak loading ELF files
- Debugger: Don't skip undefined instructions when debugger attached - Debugger: Don't skip undefined instructions when debugger attached
- FFmpeg: Fix some small memory leaks - FFmpeg: Fix some small memory leaks
- FFmpeg: Fix encoding of time base - FFmpeg: Fix encoding of time base

2
src/core/core.c
View File

@ -387,9 +387,11 @@ bool mCoreLoadELF(struct mCore* core, struct ELF* elf) {
if (block && bsize >= phdr->p_filesz && esize > phdr->p_offset && esize >= phdr->p_filesz + phdr->p_offset) { if (block && bsize >= phdr->p_filesz && esize > phdr->p_offset && esize >= phdr->p_filesz + phdr->p_offset) {
memcpy(block, &bytes[phdr->p_offset], phdr->p_filesz); memcpy(block, &bytes[phdr->p_offset], phdr->p_filesz);
} else { } else {
ELFProgramHeadersDeinit(&ph);
return false; return false;
} }
} }
ELFProgramHeadersDeinit(&ph);
return true; return true;
} }