ShuriZma
/
mgba
mirror of https://github.com/mgba-emu/mgba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Qt: Pay down a bit of MemoryAccessLogView tech debt

This commit is contained in:
Vicki Pfau 2024-01-30 02:51:32 -08:00
parent c0a323dbcd
commit 3133105fc9
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/platform/qt/MemoryAccessLogView.cpp
View File

@ -8,6 +8,7 @@
#include <QVBoxLayout> #include <QVBoxLayout>
#include "GBAApp.h" #include "GBAApp.h"
#include "LogController.h"
#include "utils.h" #include "utils.h"
#include "VFileDevice.h" #include "VFileDevice.h"
@ -78,7 +79,7 @@ void MemoryAccessLogView::start() {
m_controller->attachDebuggerModule(&m_logger.d); m_controller->attachDebuggerModule(&m_logger.d);
if (!mDebuggerAccessLoggerOpen(&m_logger, vf, flags)) { if (!mDebuggerAccessLoggerOpen(&m_logger, vf, flags)) {
mDebuggerAccessLoggerDeinit(&m_logger); mDebuggerAccessLoggerDeinit(&m_logger);
// log error LOG(QT, ERROR) << tr("Failed to open memory log file");
return; return;
} }

2
src/platform/qt/MemoryAccessLogView.h
View File

@ -44,7 +44,7 @@ private:
QSet<QString> m_watchedRegions; QSet<QString> m_watchedRegions;
QHash<QString, QCheckBox*> m_regionBoxes; QHash<QString, QCheckBox*> m_regionBoxes;
QHash<QString, int> m_regionMapping; QHash<QString, int> m_regionMapping;
struct mDebuggerAccessLogger m_logger; struct mDebuggerAccessLogger m_logger{};
bool m_active = false; bool m_active = false;
mDebuggerAccessLogRegionFlags activeFlags() const; mDebuggerAccessLogRegionFlags activeFlags() const;