ShuriZma
/
mgba
mirror of https://github.com/mgba-emu/mgba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Util: Reject 0-width/height images

This commit is contained in:
Vicki Pfau 2023-04-01 22:30:57 -07:00
parent 6d719b529a
commit 285f22927b
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/util/image.c
View File

@ -14,6 +14,9 @@
#define ROW(IM, Y) PIXEL(IM, 0, Y)
struct mImage* mImageCreate(unsigned width, unsigned height, enum mColorFormat format) {
if (width < 1 || height < 1) {
return NULL;
}
struct mImage* image = calloc(1, sizeof(struct mImage));
if (!image) {
return NULL;

10
src/util/test/image.c
View File

@ -11,6 +11,15 @@
#endif
#include <mgba-util/vfs.h>
M_TEST_DEFINE(zeroDim) {
assert_null(mImageCreate(0, 0, mCOLOR_ABGR8));
assert_null(mImageCreate(1, 0, mCOLOR_ABGR8));
assert_null(mImageCreate(0, 1, mCOLOR_ABGR8));
struct mImage* image = mImageCreate(1, 1, mCOLOR_ABGR8);
assert_non_null(image);
mImageDestroy(image);
}
M_TEST_DEFINE(pitchRead) {
static uint8_t buffer[12] = {
0x0, 0x1, 0x2, 0x3, 0x4, 0x5, 0x6, 0x7, 0x8, 0x9, 0xA, 0xB
@ -695,6 +704,7 @@ M_TEST_DEFINE(convert2x2) {
}
M_TEST_SUITE_DEFINE(Image,
cmocka_unit_test(zeroDim),
cmocka_unit_test(pitchRead),
cmocka_unit_test(strideRead),
cmocka_unit_test(oobRead),