ShuriZma
/
mgba
mirror of https://github.com/mgba-emu/mgba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GDB Stub: use only hardware breakpoints regardless of GDB's request 

This will ignore GDB's request for a software breakpoint as they can be very unreliable in determining whether it should be thumb or ARM.
This commit is contained in:
aldelaro5 2021-12-25 01:05:07 -05:00 committed by Vicki Pfau
parent d4f1838a4a
commit 27809bd1a3
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/debugger/gdb-stub.c
View File

@ -487,7 +487,6 @@ static void _setBreakpoint(struct GDBStub* stub, const char* message) {
unsigned i = 0;
uint32_t address = _readHex(readAddress, &i);
readAddress += i + 1;
uint32_t kind = _readHex(readAddress, &i);
struct mBreakpoint breakpoint = {
.address = address,
@ -499,8 +498,6 @@ static void _setBreakpoint(struct GDBStub* stub, const char* message) {
switch (message[0]) {
case '0':
ARMDebuggerSetSoftwareBreakpoint(stub->d.platform, address, kind == 2 ? MODE_THUMB : MODE_ARM);
break;
case '1':
stub->d.platform->setBreakpoint(stub->d.platform, &breakpoint);
break;