GB, GBA: Fix crashes when attempting to identify null VFiles

This commit is contained in:
Vicki Pfau 2017-07-29 17:32:36 -07:00
parent 8684a0b221
commit 0d6a0ed375
3 changed files with 7 additions and 0 deletions

View File

@ -10,6 +10,7 @@ Bugfixes:
- GB Core: Fix palette loading when loading a foreign config
- Qt: Fix LOG argument order
- GB Memory: Prevent accessing empty SRAM (fixes mgba.io/i/831)
- GB, GBA: Fix crashes when attempting to identify null VFiles
Misc:
- Qt: Don't rebuild library view if style hasn't changed
- SDL: Fix 2.0.5 build on macOS under some circumstances

View File

@ -655,6 +655,9 @@ void GBIllegal(struct LR35902Core* cpu) {
}
bool GBIsROM(struct VFile* vf) {
if (!vf) {
return false;
}
vf->seek(vf, 0x104, SEEK_SET);
uint8_t header[4];

View File

@ -475,6 +475,9 @@ void GBADebug(struct GBA* gba, uint16_t flags) {
}
bool GBAIsROM(struct VFile* vf) {
if (!vf) {
return false;
}
if (vf->seek(vf, GBA_ROM_MAGIC_OFFSET, SEEK_SET) < 0) {
return false;
}