ShuriZma
/
mgba
mirror of https://github.com/mgba-emu/mgba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GBA I/O: Stop logging several harmless invalid register reads

This commit is contained in:
Vicki Pfau 2019-12-29 16:42:10 -08:00
parent 1f6126d124
commit 01656e6052
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES
View File

@ -107,6 +107,7 @@ Other fixes:
- Qt: Fix sprite view using wrong base address (fixes mgba.io/i/1603)
Misc:
- GB Memory: Support manual SRAM editing (fixes mgba.io/i/1580)
- GBA I/O: Stop logging several harmless invalid register reads
- Debugger: Separate aliases from main commands
- Debugger: Print break-/watchpoint ID when breaking in CLI
- SDL: Use controller GUID instead of name

8
src/gba/io.c
View File

@ -826,8 +826,10 @@ uint16_t GBAIORead(struct GBA* gba, uint32_t address) {
case REG_DMA1CNT_LO:
case REG_DMA2CNT_LO:
case REG_DMA3CNT_LO:
// Write-only register
mLOG(GBA_IO, GAME_ERROR, "Read from write-only I/O register: %03X", address);
// Many, many things read from the DMA register
case REG_MAX:
// Some bad interrupt libraries will read from this
// (Silent) write-only register
return 0;
case REG_JOY_RECV_LO:
@ -900,8 +902,6 @@ uint16_t GBAIORead(struct GBA* gba, uint32_t address) {
case REG_IME:
// Handled transparently by registers
break;
case REG_MAX:
// Some bad interrupt libraries will read from this
case 0x066:
case 0x06E:
case 0x076: