From d31eabb6fa5d80e90c6f9849af5a05b05ce362f3 Mon Sep 17 00:00:00 2001
From: Nadia Holmquist Pedersen <nadia@nhp.sh>
Date: Sat, 27 Jul 2024 16:55:49 +0200
Subject: [PATCH] Don't disable firmware settings controls when override
 external firmware settings is disabled

---
 src/frontend/qt_sdl/FirmwareSettingsDialog.cpp | 9 ---------
 src/frontend/qt_sdl/FirmwareSettingsDialog.h   | 1 -
 2 files changed, 10 deletions(-)

diff --git a/src/frontend/qt_sdl/FirmwareSettingsDialog.cpp b/src/frontend/qt_sdl/FirmwareSettingsDialog.cpp
index a2510c2d..5d5ecd01 100644
--- a/src/frontend/qt_sdl/FirmwareSettingsDialog.cpp
+++ b/src/frontend/qt_sdl/FirmwareSettingsDialog.cpp
@@ -72,8 +72,6 @@ FirmwareSettingsDialog::FirmwareSettingsDialog(QWidget* parent) : QDialog(parent
 
     ui->txtMAC->setText(firmcfg.GetQString("MAC"));
 
-    on_overrideFirmwareBox_toggled();
-
     int inst = emuInstance->getInstanceID();
     if (inst > 0)
         ui->lblInstanceNum->setText(QString("Configuring settings for instance %1").arg(inst+1));
@@ -225,10 +223,3 @@ void FirmwareSettingsDialog::on_cbxBirthdayMonth_currentIndexChanged(int idx)
         }
     }
 }
-
-void FirmwareSettingsDialog::on_overrideFirmwareBox_toggled()
-{
-    bool disable = !ui->overrideFirmwareBox->isChecked();
-    ui->grpUserSettings->setDisabled(disable);
-    ui->grpWifiSettings->setDisabled(disable);
-}
diff --git a/src/frontend/qt_sdl/FirmwareSettingsDialog.h b/src/frontend/qt_sdl/FirmwareSettingsDialog.h
index d80d370b..2053ab99 100644
--- a/src/frontend/qt_sdl/FirmwareSettingsDialog.h
+++ b/src/frontend/qt_sdl/FirmwareSettingsDialog.h
@@ -125,7 +125,6 @@ private slots:
     void done(int r);
 
     void on_cbxBirthdayMonth_currentIndexChanged(int idx);
-    void on_overrideFirmwareBox_toggled();
 
 private:
     bool verifyMAC();