ShuriZma
/
melonDS
mirror of https://github.com/melonDS-emu/melonDS.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Clarify comments and credit DeSmuME for Flash I/O

This commit is contained in:
Raphaël Zumer 2019-12-10 09:57:10 -05:00
parent 68d3474458
commit 4d1f3d419e
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/GBACart.cpp
View File

@ -36,6 +36,7 @@ enum SaveType {
S_FLASH1M S_FLASH1M
}; };
// from DeSmuME
struct FlashProperties struct FlashProperties
{ {
u8 state; u8 state;
@ -179,6 +180,7 @@ void RelocateSave(const char* path, bool write)
fwrite(SRAM, SRAMLength, 1, SRAMFile); fwrite(SRAM, SRAMLength, 1, SRAMFile);
} }
// mostly ported from DeSmuME
u8 Read_Flash(u32 addr) u8 Read_Flash(u32 addr)
{ {
if (SRAMFlash.cmd == 0) // no cmd if (SRAMFlash.cmd == 0) // no cmd
@ -196,10 +198,10 @@ u8 Read_Flash(u32 addr)
SRAMFlash.state = 0; SRAMFlash.state = 0;
SRAMFlash.cmd = 0; SRAMFlash.cmd = 0;
break; break;
case 0xA0: // erase command case 0xA0: // write command
break; // ignore here, handled during writes break; // ignore here, handled in Write_Flash()
case 0xB0: // bank switching (128K only) case 0xB0: // bank switching (128K only)
break; // ignore here, handled during writes break; // ignore here, handled in Write_Flash()
default: default:
printf("GBACart_SRAM::Read_Flash: unknown command 0x%02X @ 0x%04X\n", SRAMFlash.cmd, addr); printf("GBACart_SRAM::Read_Flash: unknown command 0x%02X @ 0x%04X\n", SRAMFlash.cmd, addr);
break; break;
@ -215,6 +217,7 @@ void Write_EEPROM(u32 addr, u8 val)
// TODO: could be used in homebrew? // TODO: could be used in homebrew?
} }
// mostly ported from DeSmuME
void Write_Flash(u32 addr, u8 val) void Write_Flash(u32 addr, u8 val)
{ {
switch (SRAMFlash.state) switch (SRAMFlash.state)
@ -352,7 +355,6 @@ void Write_SRAM(u32 addr, u8 val)
{ {
u8 prev = *(u8*)&SRAM[addr]; u8 prev = *(u8*)&SRAM[addr];
// TODO: try not to do this for every byte
if (prev != val) if (prev != val)
{ {
*(u8*)&SRAM[addr] = val; *(u8*)&SRAM[addr] = val;