Avoid retrieving preferences from static function
Unify numerous calls to the same fragment
Not entirely sure why I added more when this is much cleaner
Avoid a redundant call to SharedPreferences
Cleanup, Fix regressions, Finalize design changes
This fixes a few minor issues, including the missing title when options is opened from file browser, the release build product being named debug, and the possibility that JNIdc.config is not set when opening the BIOS without a game selected.
Nobody actually understood where the "Files Dir" path was located and this led to more confusion than useful information. It also prevents the message from being overlapped.
Remove unused / ignored Snackbar parameters
At one point, this was necessary(?). It appears to be problematic and the root cause of an unnecessary FileNotFoundException. Apache's FileUtils will create the directory and file, if necessary, when using version 1.3+ of the io library. This avoids maintaining workarounds.
An xml view will never not exist, but it may be empty. Check the appropriate condition to avoid a crash.
Fix some error checking for file list clearing
Assign activity menu icon to activity Snackbar
Unify appearance of Snackbar, Fix overlap in log sender
See https://stackoverflow.com/a/49583210/461982 for the StackOverflow submission on modifying Snackbar location.
Most UI settings should be saved asynchronously with immediate results few from runtime memory, but storing the keys for cloud saves should probably remain direct to disk with error checking.
Rather than attempt to locate each vector reference, it was best to extend the application for global support. This created a good place to handle native options that are separate from UI config
Clean up formatting and remove whitespace
Android Sudio does not verify global variables well
Conflicts:
shell/android-studio/app/src/main/java/com/reicast/emulator/GL2JNINative.java
The permission request is not necessary on rooted devices and the emulator may not run on non-root devices. This permissions simply circumvents a crash so the user can be notified of incompatibility through means other than a crash.
TwistedUmbrella