From d90243a2c9104c052d825e6e3be6af419161ad9b Mon Sep 17 00:00:00 2001 From: Lioncash Date: Thu, 6 Mar 2014 03:28:15 -0500 Subject: [PATCH] [Android] Replace string .equals("") tests in conditionals with .isEmpty() --- shell/android/src/com/reicast/emulator/AboutFragment.java | 2 +- shell/android/src/com/reicast/emulator/debug/GitAdapter.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/shell/android/src/com/reicast/emulator/AboutFragment.java b/shell/android/src/com/reicast/emulator/AboutFragment.java index 28f48973d..2dd9e477a 100644 --- a/shell/android/src/com/reicast/emulator/AboutFragment.java +++ b/shell/android/src/com/reicast/emulator/AboutFragment.java @@ -139,7 +139,7 @@ public class AboutFragment extends Fragment { R.id.revision_text); String revision = parentActivity.getString(R.string.revision_text, versionName, String.valueOf(versionCode)); - if (!buildId.equals("")) { + if (!buildId.isEmpty()) { revision = parentActivity.getString(R.string.revision_text, versionName, buildId.substring(0,7)); } diff --git a/shell/android/src/com/reicast/emulator/debug/GitAdapter.java b/shell/android/src/com/reicast/emulator/debug/GitAdapter.java index 49806f015..fd5de15dd 100644 --- a/shell/android/src/com/reicast/emulator/debug/GitAdapter.java +++ b/shell/android/src/com/reicast/emulator/debug/GitAdapter.java @@ -145,7 +145,7 @@ public class GitAdapter extends BaseAdapter { final String current = commit.get("Build"); RelativeLayout item = (RelativeLayout) vi.findViewById(R.id.change); - if (current != null && !current.equals("") && current.equals(sha)) { + if (current != null && !current.isEmpty() && current.equals(sha)) { item.getBackground().setColorFilter(0xFF00FF00, PorterDuff.Mode.MULTIPLY); } else {