From d2aca1d6211b98c2077e21a9b81aba6251e8e2b0 Mon Sep 17 00:00:00 2001 From: Flyinghead Date: Mon, 20 Jun 2022 20:49:09 +0200 Subject: [PATCH] savestate: overflow crash when serializing --- core/serialize.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/core/serialize.h b/core/serialize.h index 6df6e19fa..232dec742 100644 --- a/core/serialize.h +++ b/core/serialize.h @@ -152,7 +152,7 @@ class Serializer : public SerializeBase { public: Serializer() - : SerializeBase(std::numeric_limits::max(), false), data(nullptr) { } + : Serializer(nullptr, std::numeric_limits::max(), false) {} Serializer(void *data, size_t limit, bool rollback = false) : SerializeBase(limit, rollback), data((u8 *)data) @@ -179,7 +179,6 @@ public: } void skip(size_t size) { - verify(this->_size + size <= limit); if (data != nullptr) data += size; this->_size += size; @@ -189,7 +188,6 @@ public: private: void doSerialize(const void *src, size_t size) { - verify(this->_size + size <= limit); if (data != nullptr) { memcpy(data, src, size);