ShuriZma
/
flycast
mirror of https://github.com/flyinghead/flycast.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

vk: Use matching u/v/w sampler address-mode when possible 

This addresses the `BestPractices-Arm-vkCreateSampler-different-wrapping-modes` message from ARM:
65b79bac61/layers/best_practices/bp_descriptor.cpp (L95-L100)

The `W`-axis for these samplers is always unused, it's never the case that these samplers are going to be used for 3D textures.
ARM suggests trying to keep all of the wrapping-modes the same if possible for performance.

`wRepeat` will be set to the same value as `vRepeat` to try and encourage all three wrapping-modes to be the same.
This commit is contained in:
Wunkolo 2024-10-08 19:01:53 -07:00 committed by flyinghead
parent 0c3f5c7a76
commit b94acb70a6
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
core/rend/vulkan/texture.h
View File

@ -125,6 +125,11 @@ public:
const vk::SamplerAddressMode vRepeat = tsp.ClampV ? vk::SamplerAddressMode::eClampToEdge
: tsp.FlipV ? vk::SamplerAddressMode::eMirroredRepeat : vk::SamplerAddressMode::eRepeat;
// The W-axis is unused for 2D textures
// Try to keep all three of the wrapping-modes the same by just repeating vRepeat for wRepeat
// BestPractices-Arm-vkCreateSampler-different-wrapping-modes
const vk::SamplerAddressMode wRepeat = vRepeat;
const bool anisotropicFiltering = config::AnisotropicFiltering > 1 && VulkanContext::Instance()->SupportsSamplerAnisotropy()
&& filter == vk::Filter::eLinear && !punchThrough;
#ifndef __APPLE__
@ -137,7 +142,7 @@ public:
return samplers.emplace(
std::make_pair(samplerHash, VulkanContext::Instance()->GetDevice().createSamplerUnique(
vk::SamplerCreateInfo(vk::SamplerCreateFlags(), filter, filter,
mipmapMode, uRepeat, vRepeat, vk::SamplerAddressMode::eClampToEdge, mipLodBias,
mipmapMode, uRepeat, vRepeat, wRepeat, mipLodBias,
anisotropicFiltering, std::min((float)config::AnisotropicFiltering, VulkanContext::Instance()->GetMaxSamplerAnisotropy()),
false, vk::CompareOp::eNever,
0.0f, vk::LodClampNone, vk::BorderColor::eFloatOpaqueBlack)))).first->second.get();

4
core/rend/vulkan/vulkan_driver.h
View File

@ -99,7 +99,7 @@ public:
vk::SamplerMipmapMode::eNearest,
vk::SamplerAddressMode::eClampToBorder,
vk::SamplerAddressMode::eClampToBorder,
vk::SamplerAddressMode::eClampToEdge, 0.0f, false,
vk::SamplerAddressMode::eClampToBorder, 0.0f, false,
0.f, false, vk::CompareOp::eNever, 0.0f, VK_LOD_CLAMP_NONE,
vk::BorderColor::eFloatTransparentBlack));
}
@ -115,7 +115,7 @@ public:
vk::SamplerMipmapMode::eLinear,
vk::SamplerAddressMode::eClampToBorder,
vk::SamplerAddressMode::eClampToBorder,
vk::SamplerAddressMode::eClampToEdge, 0.0f, false,
vk::SamplerAddressMode::eClampToBorder, 0.0f, false,
0.f, false, vk::CompareOp::eNever, 0.0f, VK_LOD_CLAMP_NONE,
vk::BorderColor::eFloatTransparentBlack));
}