From 67f2162fb3b9ebdc17536705d76f169ba1dddc95 Mon Sep 17 00:00:00 2001 From: cglmrfreeman Date: Mon, 22 Nov 2021 22:22:17 -0800 Subject: [PATCH] Fix linux breakpad issues when glibc-2.34 is installed As outlined by [Samuli Piippo in the qtwebengine chromium patch](https://codereview.qt-project.org/c/yocto/meta-qt6/+/378728/2/recipes-qt/qt6/qtwebengine/chromium/0004-breakpad-fix-build-with-glibc-2.34.patch), SIGSTCKZ is no longer being compile time constant in glibc-2.34. The proposed fix compiles on my end and I have not tested on a linux distro with an earlier version of glibc. --- .../deps/breakpad/src/client/linux/handler/exception_handler.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/deps/breakpad/src/client/linux/handler/exception_handler.cc b/core/deps/breakpad/src/client/linux/handler/exception_handler.cc index ca353c409..2e43ba6fc 100644 --- a/core/deps/breakpad/src/client/linux/handler/exception_handler.cc +++ b/core/deps/breakpad/src/client/linux/handler/exception_handler.cc @@ -138,7 +138,7 @@ void InstallAlternateStackLocked() { // SIGSTKSZ may be too small to prevent the signal handlers from overrunning // the alternative stack. Ensure that the size of the alternative stack is // large enough. - static const unsigned kSigStackSize = std::max(16384, SIGSTKSZ); + static const unsigned kSigStackSize = std::max(16384, SIGSTKSZ); // Only set an alternative stack if there isn't already one, or if the current // one is too small.