ShuriZma
/
fceux
mirror of https://github.com/TASEmulators/fceux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Resolved cppcheck warnings in win/header_editor.cpp

This commit is contained in:
Matthew Budd 2020-06-15 22:21:54 -04:00
parent 96cba27965
commit e6329b911a
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/drivers/win/header_editor.cpp
View File

@ -1454,7 +1454,7 @@ int GetComboBoxByteSize(HWND hwnd, UINT id, int* value)
if (!GetComboBoxListItemData(hwnd, id, value, buf, true)) if (!GetComboBoxListItemData(hwnd, id, value, buf, true))
{ {
char buf2[4]; char buf2[4];
if (sscanf(buf, "%d%[KMB]", value, buf2) < 2 || !strcmp(buf2, "")) if (sscanf(buf, "%d%3[KMB]", value, buf2) < 2 || !strcmp(buf2, ""))
err = errors::FORMAT_ERR; err = errors::FORMAT_ERR;
else else
{ {
@ -1524,15 +1524,15 @@ bool GetComboBoxListItemData(HWND hwnd, UINT id, int* value, char* buf, bool exa
case IDC_VS_SYSTEM_COMBO: case IDC_VS_SYSTEM_COMBO:
case IDC_VS_PPU_COMBO: case IDC_VS_PPU_COMBO:
case IDC_SYSTEM_EXTEND_COMBO: case IDC_SYSTEM_EXTEND_COMBO:
if (!(success = sscanf(buf, "$%X", value) > 0)) if (!(success = sscanf(buf, "$%X", (unsigned int *)value) > 0))
success = SearchByString(hwnd, id, value, buf); success = SearchByString(hwnd, id, value, buf);
else else
SetDlgItemText(hwnd, id, buf); SetDlgItemText(hwnd, id, buf);
break; break;
case IDC_INPUT_DEVICE_COMBO: case IDC_INPUT_DEVICE_COMBO:
if (success = sscanf(buf, "$%X", value) > 0) if (success = sscanf(buf, "$%X", (unsigned int *)value) > 0)
{ {
char buf2[3]; char buf2[8];
sprintf(buf2, "$%02X", *value); sprintf(buf2, "$%02X", *value);
if (SendDlgItemMessage(hwnd, id, CB_SELECTSTRING, 0, (LPARAM)buf2) == CB_ERR) if (SendDlgItemMessage(hwnd, id, CB_SELECTSTRING, 0, (LPARAM)buf2) == CB_ERR)
SetDlgItemText(hwnd, id, buf); SetDlgItemText(hwnd, id, buf);
@ -1694,4 +1694,4 @@ bool SearchByString(HWND hwnd, UINT id, int* value, char* buf)
} }
return false; return false;
} }