From d2a3b310b3b303a2c379312ab558a4ea42a79ec6 Mon Sep 17 00:00:00 2001 From: zeromus Date: Sun, 29 Mar 2009 22:25:17 +0000 Subject: [PATCH] last minute code tweaks --- src/boards/mmc1.cpp | 8 +++++--- src/boards/mmc5.cpp | 9 ++++++--- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/src/boards/mmc1.cpp b/src/boards/mmc1.cpp index 1a78eb7a..d62b03fc 100644 --- a/src/boards/mmc1.cpp +++ b/src/boards/mmc1.cpp @@ -323,9 +323,11 @@ static void GenMMC1Init(CartInfo *info, int prg, int chr, int wram, int battery) if(wram) { WRAM=(uint8*)FCEU_gmalloc(wram*1024); - //mbg 6/17/08 - this shouldve been cleared to re-initialize save ram - //ch4 10/12/08 - nope, this souldn't - //memset(WRAM,0,wram*1024); + //mbg 17-jun-08 - this shouldve been cleared to re-initialize save ram + //ch4 10-dec-08 - nope, this souldn't + //mbg 29-mar-09 - no time to debate this, we need to keep from breaking some old stuff. + //we really need to make up a policy for how compatibility and accuracy can be resolved. + memset(WRAM,0,wram*1024); mmc1opts|=1; if(wram>8) mmc1opts|=4; SetupCartPRGMapping(0x10,WRAM,wram*1024,1); diff --git a/src/boards/mmc5.cpp b/src/boards/mmc5.cpp index 120bb3c5..771be44a 100644 --- a/src/boards/mmc5.cpp +++ b/src/boards/mmc5.cpp @@ -165,12 +165,15 @@ int DetectMMC5WRAMSize(uint32 crc32) } } - //mbg 8/4/08 - previously, this was returning 8KB + //mbg 04-aug-08 - previously, this was returning 8KB //but I changed it to return 64 because unlisted carts are probably homebrews, and they should probably use 64 (why not use it all?) - //ch4 10/12/08 - then f***ng for what all this shit above? let's give em all this 64k shit! Damn + //ch4 10-dec-08 - then f***ng for what all this shit above? let's give em all this 64k shit! Damn // homebrew must use it's own emulators or standart features. - //adelikat 12/20/08 - reverting back to return 64, sounds like it was changed back to 8 simply on principle. FCEUX is all encompassing, and that include + //adelikat 20-dec-08 - reverting back to return 64, sounds like it was changed back to 8 simply on principle. FCEUX is all encompassing, and that include //rom-hacking. We want it to be the best emulator for such purposes. So unless return 64 harms compatibility with anything else, I see now reason not to have it + //mbg 29-mar-09 - I should note that mmc5 is in principle capable of 64KB, even if no real carts ever supported it. + //This does not in principle break any games which share this mapper, and it should be OK for homebrew. + //if there are games which need 8KB instead of 64KB default then lets add them to the list return 64; }