From 66e2576595e1aaae74475a0a13a27ae283ecce2c Mon Sep 17 00:00:00 2001 From: harry Date: Mon, 6 Feb 2023 21:26:40 -0500 Subject: [PATCH] Fixed string over-read in win port by added a exit condition for loop in ASM debugger logic. --- src/drivers/win/debugger.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/drivers/win/debugger.cpp b/src/drivers/win/debugger.cpp index 4ffc1c73..a688a636 100644 --- a/src/drivers/win/debugger.cpp +++ b/src/drivers/win/debugger.cpp @@ -481,7 +481,7 @@ void HighlightSyntax(HWND hWnd, int lines) { commentline = false; wordbreak = SendDlgItemMessage(hWnd, IDC_DEBUGGER_DISASSEMBLY, EM_FINDWORDBREAK, (WPARAM)WB_RIGHT, (LPARAM)newline.chrg.cpMin + 21); - for (int ch = newline.chrg.cpMin; ; ch++) + for (int ch = newline.chrg.cpMin; debug_wstr[ch] != 0; ch++) { if (debug_wstr[ch] == L'=' || debug_wstr[ch] == L'@' || debug_wstr[ch] == L'\n' || debug_wstr[ch] == L'-' || debug_wstr[ch] == L';') {