From 56c0d30f83ba63d45e8426b68f43c1d716eab963 Mon Sep 17 00:00:00 2001 From: harry Date: Sun, 19 Feb 2023 15:22:34 -0500 Subject: [PATCH] Fix crash in Qt CDL when cdloggerVideoDataSize is zero. --- src/drivers/Qt/CodeDataLogger.cpp | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/drivers/Qt/CodeDataLogger.cpp b/src/drivers/Qt/CodeDataLogger.cpp index 62d49dbb..8d6b5908 100644 --- a/src/drivers/Qt/CodeDataLogger.cpp +++ b/src/drivers/Qt/CodeDataLogger.cpp @@ -790,7 +790,14 @@ void InitCDLog(void) if (!CHRram[0] || (CHRptr[0] == PRGptr[0])) { // Some kind of workaround for my OneBus VRAM hack, will remove it if I find another solution for that cdloggerVideoDataSize = CHRsize[0]; - cdloggervdata = (unsigned char *)malloc(cdloggerVideoDataSize); + if (cdloggerVideoDataSize > 0) + { + cdloggervdata = (unsigned char *)malloc(cdloggerVideoDataSize); + } + else + { + cdloggervdata = nullptr; + } } else { @@ -832,7 +839,10 @@ void ResetCDLog(void) if (GameInfo->type != GIT_NSF) { undefinedvromcount = 8192; - memset(cdloggervdata, 0, 8192); + if (cdloggervdata != NULL) + { + memset(cdloggervdata, 0, 8192); + } } } FCEU_WRAPPER_UNLOCK();