ShuriZma
/
duckstation
mirror of https://github.com/stenzek/duckstation
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GPU: Fix incorrect sign extension of positions 

Fixes missing objects in Skullmonkeys (again).
This commit is contained in:
Connor McLaughlin 2020-10-11 11:57:32 +10:00
parent a46d304d79
commit fe25f005c2
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/bitfield.h
View File

@ -119,7 +119,7 @@ struct BitField
}
else if constexpr (std::is_signed_v<DataType>)
{
constexpr int shift = 8 * sizeof(DataType) - BitCount + 1;
constexpr int shift = 8 * sizeof(DataType) - BitCount;
return (static_cast<DataType>(data >> BitIndex) << shift) >> shift;
}
else

6
src/core/gpu.h
View File

@ -303,12 +303,12 @@ protected:
{
u32 bits;
BitField<u32, s32, 0, 12> x;
BitField<u32, s32, 16, 12> y;
BitField<u32, s32, 0, 11> x;
BitField<u32, s32, 16, 11> y;
};
// Sprites/rectangles should be clipped to 12 bits before drawing.
static constexpr s32 TruncateVertexPosition(s32 x) { return SignExtendN<12, s32>(x); }
static constexpr s32 TruncateVertexPosition(s32 x) { return SignExtendN<11, s32>(x); }
struct NativeVertex
{

4
src/core/gpu_sw.cpp
View File

@ -236,8 +236,8 @@ void GPU_SW::DispatchRenderCommand()
vert.b = Truncate8(color_rgb >> 16);
const VertexPosition vp{FifoPop()};
vert.x = TruncateVertexPosition(m_drawing_offset.x + vp.x);
vert.y = TruncateVertexPosition(m_drawing_offset.y + vp.y);
vert.x = m_drawing_offset.x + vp.x;
vert.y = m_drawing_offset.y + vp.y;
if (textured)
{