ShuriZma
/
duckstation
mirror of https://github.com/stenzek/duckstation
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

System: Don't time memory load/save states by default 

Reduces log spam.
This commit is contained in:
Connor McLaughlin 2021-08-08 12:58:02 +10:00
parent 5868901280
commit c4f0dafb1f
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/core/system.cpp
View File

@ -45,6 +45,8 @@
#include <thread> #include <thread>
Log_SetChannel(System); Log_SetChannel(System);
// #define PROFILE_MEMORY_SAVE_STATES 1
SystemBootParameters::SystemBootParameters() = default; SystemBootParameters::SystemBootParameters() = default;
SystemBootParameters::SystemBootParameters(SystemBootParameters&& other) = default; SystemBootParameters::SystemBootParameters(SystemBootParameters&& other) = default;
@ -2323,7 +2325,9 @@ bool SaveMemoryState(MemorySaveState* mss)
bool SaveRewindState() bool SaveRewindState()
{ {
#ifdef PROFILE_MEMORY_SAVE_STATES
Common::Timer save_timer; Common::Timer save_timer;
#endif
// try to reuse the frontmost slot // try to reuse the frontmost slot
const u32 save_slots = g_settings.rewind_save_slots; const u32 save_slots = g_settings.rewind_save_slots;
@ -2339,8 +2343,10 @@ bool SaveRewindState()
s_rewind_states.push_back(std::move(mss)); s_rewind_states.push_back(std::move(mss));
#ifdef PROFILE_MEMORY_SAVE_STATES
Log_DevPrintf("Saved rewind state (%" PRIu64 " bytes, took %.4f ms)", s_rewind_states.back().state_stream->GetSize(), Log_DevPrintf("Saved rewind state (%" PRIu64 " bytes, took %.4f ms)", s_rewind_states.back().state_stream->GetSize(),
save_timer.GetTimeMilliseconds()); save_timer.GetTimeMilliseconds());
#endif
return true; return true;
} }
@ -2356,7 +2362,9 @@ bool LoadRewindState(u32 skip_saves /*= 0*/, bool consume_state /*=true */)
if (s_rewind_states.empty()) if (s_rewind_states.empty())
return false; return false;
#ifdef PROFILE_MEMORY_SAVE_STATES
Common::Timer load_timer; Common::Timer load_timer;
#endif
if (!LoadMemoryState(s_rewind_states.back())) if (!LoadMemoryState(s_rewind_states.back()))
return false; return false;
@ -2364,7 +2372,10 @@ bool LoadRewindState(u32 skip_saves /*= 0*/, bool consume_state /*=true */)
if (consume_state) if (consume_state)
s_rewind_states.pop_back(); s_rewind_states.pop_back();
#ifdef PROFILE_MEMORY_SAVE_STATES
Log_DevPrintf("Rewind load took %.4f ms", load_timer.GetTimeMilliseconds()); Log_DevPrintf("Rewind load took %.4f ms", load_timer.GetTimeMilliseconds());
#endif
return true; return true;
} }
@ -2432,8 +2443,10 @@ void SaveRunaheadState()
void DoRunahead() void DoRunahead()
{ {
#ifdef PROFILE_MEMORY_SAVE_STATES
Common::Timer timer; Common::Timer timer;
Log_DevPrintf("runahead starting at frame %u", s_frame_number); Log_DevPrintf("runahead starting at frame %u", s_frame_number);
#endif
if (s_runahead_replay_pending) if (s_runahead_replay_pending)
{ {
@ -2448,7 +2461,10 @@ void DoRunahead()
// and throw away all the states, forcing us to catch up below // and throw away all the states, forcing us to catch up below
// TODO: can we leave one frame here and run, avoiding the extra save? // TODO: can we leave one frame here and run, avoiding the extra save?
s_runahead_states.clear(); s_runahead_states.clear();
#ifdef PROFILE_MEMORY_SAVE_STATES
Log_VerbosePrintf("Rewound to frame %u, took %.2f ms", s_frame_number, timer.GetTimeMilliseconds()); Log_VerbosePrintf("Rewound to frame %u, took %.2f ms", s_frame_number, timer.GetTimeMilliseconds());
#endif
} }
// run the frames with no audio // run the frames with no audio
@ -2469,7 +2485,9 @@ void DoRunahead()
g_spu.SetAudioStream(g_host_interface->GetAudioStream()); g_spu.SetAudioStream(g_host_interface->GetAudioStream());
#ifdef PROFILE_MEMORY_SAVE_STATES
Log_VerbosePrintf("Running %d frames to catch up took %.2f ms", temp, timer2.GetTimeMilliseconds()); Log_VerbosePrintf("Running %d frames to catch up took %.2f ms", temp, timer2.GetTimeMilliseconds());
#endif
} }
else else
{ {
@ -2477,7 +2495,9 @@ void DoRunahead()
SaveRunaheadState(); SaveRunaheadState();
} }
#ifdef PROFILE_MEMORY_SAVE_STATES
Log_DevPrintf("runahead ending at frame %u, took %.2f ms", s_frame_number, timer.GetTimeMilliseconds()); Log_DevPrintf("runahead ending at frame %u, took %.2f ms", s_frame_number, timer.GetTimeMilliseconds());
#endif
} }
void DoMemorySaveStates() void DoMemorySaveStates()
@ -2504,7 +2524,10 @@ void SetRunaheadReplayFlag()
if (s_runahead_frames == 0 || s_runahead_states.empty()) if (s_runahead_frames == 0 || s_runahead_states.empty())
return; return;
#ifdef PROFILE_MEMORY_SAVE_STATES
Log_DevPrintf("Runahead rewind pending..."); Log_DevPrintf("Runahead rewind pending...");
#endif
s_runahead_replay_pending = true; s_runahead_replay_pending = true;
} }