ShuriZma
/
duckstation
mirror of https://github.com/stenzek/duckstation
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Qt: Improve binding widget tooltip

This commit is contained in:
Stenzek 2024-12-08 02:54:06 +10:00
parent 2999f15d7a
commit b6eb41e2cf
No known key found for this signature in database
1 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/duckstation-qt/inputbindingwidgets.cpp
View File

@ -10,6 +10,7 @@
#include "core/host.h" #include "core/host.h"
#include "common/bitutils.h" #include "common/bitutils.h"
#include "common/string_util.h"
#include <QtCore/QTimer> #include <QtCore/QTimer>
#include <QtGui/QKeyEvent> #include <QtGui/QKeyEvent>
@ -61,26 +62,22 @@ void InputBindingWidget::initialize(SettingsInterface* sif, InputBindingInfo::Ty
void InputBindingWidget::updateText() void InputBindingWidget::updateText()
{ {
static constexpr const char* help_text =
QT_TR_NOOP("Left-click to change binding.\nShift-click to set multiple bindings.");
static constexpr const char* help_clear_text = QT_TR_NOOP("Right-click to remove binding.");
if (m_bindings.empty()) if (m_bindings.empty())
{ {
setText(QString()); setText(QString());
setToolTip(QStringLiteral("%1\n\n%2").arg(tr("No binding set.")).arg(tr(help_text)));
} }
else if (m_bindings.size() > 1) else if (m_bindings.size() > 1)
{ {
setText(tr("%n bindings", "", static_cast<int>(m_bindings.size()))); setText(tr("%n bindings", "", static_cast<int>(m_bindings.size())));
// keep the full thing for the tooltip // keep the full thing for the tooltip
std::stringstream ss; const QString qss = QString::fromStdString(StringUtil::JoinString(m_bindings.begin(), m_bindings.end(), "\n"));
bool first = true; setToolTip(QStringLiteral("%1\n\n%2\n%3").arg(qss).arg(tr(help_text)).arg(help_clear_text));
for (const std::string& binding : m_bindings)
{
if (first)
first = false;
else
ss << "\n";
ss << binding;
}
setToolTip(QString::fromStdString(ss.str()));
} }
else else
{ {
@ -93,6 +90,7 @@ void InputBindingWidget::updateText()
if (binding_text.length() > 35) if (binding_text.length() > 35)
binding_text = binding_text.left(35).append(QStringLiteral("...")); binding_text = binding_text.left(35).append(QStringLiteral("..."));
setText(binding_text); setText(binding_text);
setToolTip(QStringLiteral("%1\n\n%2\n%3").arg(binding_text).arg(tr(help_text)).arg(tr(help_clear_text)));
} }
} }