Move game settings apply to CommonHostInterface

android/app/src/cpp/android_host_interface.cpp

@@ -583,7 +583,6 @@ void AndroidHostInterface::OnRunningGameChanged(const std::string& path, CDImage
                                                 const std::string& game_title)
 {
   CommonHostInterface::OnRunningGameChanged(path, image, game_code, game_title);
-  ApplySettings(true);
 
   if (m_emulation_activity_object)
   {

src/duckstation-nogui/nogui_host_interface.cpp

@@ -186,16 +186,6 @@ void NoGUIHostInterface::ReleaseHostDisplay()
   m_display->SetVSync(true);
 }
 
-void NoGUIHostInterface::OnRunningGameChanged(const std::string& path, CDImage* image, const std::string& game_code,
-                                              const std::string& game_title)
-{
-  CommonHostInterface::OnRunningGameChanged(path, image, game_code, game_title);
-
-  // TODO: Move to common
-  if (g_settings.apply_game_settings)
-    ApplySettings(true);
-}
-
 void NoGUIHostInterface::RequestExit()
 {
   m_quit_request = true;

src/duckstation-nogui/nogui_host_interface.h

@@ -41,9 +41,6 @@ protected:
   bool AcquireHostDisplay() override;
   void ReleaseHostDisplay() override;
 
-  void OnRunningGameChanged(const std::string& path, CDImage* image, const std::string& game_code,
-                            const std::string& game_title) override;
-
   void RequestExit() override;
   virtual void PollAndUpdate() override;
 

src/duckstation-qt/qthostinterface.cpp

@@ -676,7 +676,6 @@ void QtHostInterface::OnRunningGameChanged(const std::string& path, CDImage* ima
                                            const std::string& game_title)
 {
   CommonHostInterface::OnRunningGameChanged(path, image, game_code, game_title);
-  applySettings(true);
 
   if (!System::IsShutdown())
   {

src/frontend-common/common_host_interface.cpp

@@ -911,6 +911,9 @@ void CommonHostInterface::OnRunningGameChanged(const std::string& path, CDImage*
 {
   HostInterface::OnRunningGameChanged(path, image, game_code, game_title);
 
+  if (g_settings.apply_game_settings)
+    ApplySettings(true);
+
   if (!System::IsShutdown())
   {
     System::SetCheatList(nullptr);