From 8ccee29694c1d39dce5e3afbac70e60ce78d09a8 Mon Sep 17 00:00:00 2001
From: qurious-pixel <62252937+qurious-pixel@users.noreply.github.com>
Date: Tue, 19 Oct 2021 07:44:24 -0700
Subject: [PATCH] Disable AppX signing for PRs
Allows builds to complete with unsigned UWPs
---
.github/workflows/rolling-release.yml | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/rolling-release.yml b/.github/workflows/rolling-release.yml
index e71106083..d3c68accd 100644
--- a/.github/workflows/rolling-release.yml
+++ b/.github/workflows/rolling-release.yml
@@ -185,6 +185,12 @@ jobs:
run: |
copy ${{ steps.write_signing_key.outputs.filePath }} src\duckstation-uwp\duckstation-uwp.pfx
+ - name: Disable AppX signing
+ if: github.ref != 'refs/heads/master' || github.ref != 'refs/heads/dev'
+ shell: powershell
+ run: |
+ (gc .\src\duckstation-uwp\duckstation-uwp.vcxproj) -replace 'True', 'False' | Out-File -encoding ASCII .\src\duckstation-uwp\duckstation-uwp.vcxproj
+
- name: Restore nuget packages
shell: cmd
run: |
@@ -205,7 +211,6 @@ jobs:
msbuild duckstation-uwp.sln /p:AppxBundle=Always /p:AppxPackageIsForStore=true /p:BuildAppxUploadPackageForUap=true /p:AppxBundlePlatforms="x64" /p:Configuration="ReleaseUWP" /p:Platform="x64" /t:Build
- name: Grab AppX package
- if: github.ref == 'refs/heads/master' || github.ref == 'refs/heads/dev'
shell: cmd
run: |
copy build\ReleaseUWP-x64\duckstation-uwp\duckstation-uwp_1.0.0.0_Bundle\duckstation-uwp_1.0.0.0_x64_ReleaseUWP.appx duckstation-uwp.appx
@@ -217,7 +222,6 @@ jobs:
Get-PfxCertificate -FilePath .\src\duckstation-uwp\duckstation-uwp.pfx | Export-Certificate -FilePath duckstation-uwp.der -Type CERT
- name: Upload AppX package
- if: github.ref == 'refs/heads/master' || github.ref == 'refs/heads/dev'
uses: actions/upload-artifact@v1
with:
name: "windows-uwp"