diff --git a/src/core/achievements.cpp b/src/core/achievements.cpp index 16bfd0ed7..1ccadad2d 100644 --- a/src/core/achievements.cpp +++ b/src/core/achievements.cpp @@ -955,8 +955,7 @@ void Achievements::IdentifyGame(const std::string& path, CDImage* image) } std::unique_ptr temp_image; - if (!path.empty() && (!image || (g_settings.achievements_use_first_disc_from_playlist && image->HasSubImages() && - image->GetCurrentSubImage() != 0))) + if (!path.empty() && !image) { temp_image = CDImage::Open(path.c_str(), g_settings.cdrom_load_image_patches, nullptr); image = temp_image.get(); diff --git a/src/core/settings.cpp b/src/core/settings.cpp index 401525463..c0c3a1641 100644 --- a/src/core/settings.cpp +++ b/src/core/settings.cpp @@ -416,7 +416,6 @@ void Settings::Load(const SettingsInterface& si, const SettingsInterface& contro achievements_encore_mode = si.GetBoolValue("Cheevos", "EncoreMode", false); achievements_spectator_mode = si.GetBoolValue("Cheevos", "SpectatorMode", false); achievements_unofficial_test_mode = si.GetBoolValue("Cheevos", "UnofficialTestMode", false); - achievements_use_first_disc_from_playlist = si.GetBoolValue("Cheevos", "UseFirstDiscFromPlaylist", true); achievements_use_raintegration = si.GetBoolValue("Cheevos", "UseRAIntegration", false); achievements_notification_duration = si.GetIntValue("Cheevos", "NotificationsDuration", DEFAULT_ACHIEVEMENT_NOTIFICATION_TIME); @@ -678,7 +677,6 @@ void Settings::Save(SettingsInterface& si, bool ignore_base) const si.SetBoolValue("Cheevos", "EncoreMode", achievements_encore_mode); si.SetBoolValue("Cheevos", "SpectatorMode", achievements_spectator_mode); si.SetBoolValue("Cheevos", "UnofficialTestMode", achievements_unofficial_test_mode); - si.SetBoolValue("Cheevos", "UseFirstDiscFromPlaylist", achievements_use_first_disc_from_playlist); si.SetBoolValue("Cheevos", "UseRAIntegration", achievements_use_raintegration); si.SetIntValue("Cheevos", "NotificationsDuration", achievements_notification_duration); si.SetIntValue("Cheevos", "LeaderboardsDuration", achievements_leaderboard_duration); diff --git a/src/core/settings.h b/src/core/settings.h index d30b40767..ef4ff3002 100644 --- a/src/core/settings.h +++ b/src/core/settings.h @@ -213,7 +213,6 @@ struct Settings bool achievements_encore_mode : 1 = false; bool achievements_spectator_mode : 1 = false; bool achievements_unofficial_test_mode : 1 = false; - bool achievements_use_first_disc_from_playlist : 1 = true; bool achievements_use_raintegration : 1 = false; s32 achievements_notification_duration = DEFAULT_ACHIEVEMENT_NOTIFICATION_TIME; s32 achievements_leaderboard_duration = DEFAULT_LEADERBOARD_NOTIFICATION_TIME; diff --git a/src/duckstation-qt/achievementsettingswidget.cpp b/src/duckstation-qt/achievementsettingswidget.cpp index f4ca12fee..6b7e09a00 100644 --- a/src/duckstation-qt/achievementsettingswidget.cpp +++ b/src/duckstation-qt/achievementsettingswidget.cpp @@ -34,8 +34,6 @@ AchievementSettingsWidget::AchievementSettingsWidget(SettingsWindow* dialog, QWi SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.spectatorMode, "Cheevos", "SpectatorMode", false); SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.unofficialAchievements, "Cheevos", "UnofficialTestMode", false); - SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.useFirstDiscFromPlaylist, "Cheevos", - "UseFirstDiscFromPlaylist", true); SettingWidgetBinder::BindWidgetToFloatSetting(sif, m_ui.achievementNotificationsDuration, "Cheevos", "NotificationsDuration", Settings::DEFAULT_ACHIEVEMENT_NOTIFICATION_TIME); @@ -68,16 +66,15 @@ AchievementSettingsWidget::AchievementSettingsWidget(SettingsWindow* dialog, QWi m_ui.unofficialAchievements, tr("Test Unofficial Achievements"), tr("Unchecked"), tr("When enabled, DuckStation will list achievements from unofficial sets. Please note that these achievements are " "not tracked by RetroAchievements, so they unlock every time.")); - dialog->registerWidgetHelp( - m_ui.useFirstDiscFromPlaylist, tr("Use First Disc From Playlist"), tr("Unchecked"), - tr( - "When enabled, the first disc in a playlist will be used for achievements, regardless of which disc is active.")); connect(m_ui.enable, &QCheckBox::checkStateChanged, this, &AchievementSettingsWidget::updateEnableState); connect(m_ui.hardcoreMode, &QCheckBox::checkStateChanged, this, &AchievementSettingsWidget::updateEnableState); - connect(m_ui.hardcoreMode, &QCheckBox::checkStateChanged, this, &AchievementSettingsWidget::onHardcoreModeStateChanged); - connect(m_ui.achievementNotifications, &QCheckBox::checkStateChanged, this, &AchievementSettingsWidget::updateEnableState); - connect(m_ui.leaderboardNotifications, &QCheckBox::checkStateChanged, this, &AchievementSettingsWidget::updateEnableState); + connect(m_ui.hardcoreMode, &QCheckBox::checkStateChanged, this, + &AchievementSettingsWidget::onHardcoreModeStateChanged); + connect(m_ui.achievementNotifications, &QCheckBox::checkStateChanged, this, + &AchievementSettingsWidget::updateEnableState); + connect(m_ui.leaderboardNotifications, &QCheckBox::checkStateChanged, this, + &AchievementSettingsWidget::updateEnableState); connect(m_ui.achievementNotificationsDuration, &QSlider::valueChanged, this, &AchievementSettingsWidget::onAchievementsNotificationDurationSliderChanged); connect(m_ui.leaderboardNotificationsDuration, &QSlider::valueChanged, this, @@ -128,7 +125,6 @@ void AchievementSettingsWidget::updateEnableState() m_ui.encoreMode->setEnabled(enabled); m_ui.spectatorMode->setEnabled(enabled); m_ui.unofficialAchievements->setEnabled(enabled); - m_ui.useFirstDiscFromPlaylist->setEnabled(enabled); } void AchievementSettingsWidget::onHardcoreModeStateChanged() diff --git a/src/duckstation-qt/achievementsettingswidget.ui b/src/duckstation-qt/achievementsettingswidget.ui index dfab93e19..ec19e3334 100644 --- a/src/duckstation-qt/achievementsettingswidget.ui +++ b/src/duckstation-qt/achievementsettingswidget.ui @@ -64,13 +64,6 @@ - - - - Use First Disc From Playlist - - - @@ -97,13 +90,13 @@ 5 - Qt::Horizontal + Qt::Orientation::Horizontal false - QSlider::TicksBelow + QSlider::TickPosition::TicksBelow 1 @@ -143,13 +136,13 @@ 5 - Qt::Horizontal + Qt::Orientation::Horizontal false - QSlider::TicksBelow + QSlider::TickPosition::TicksBelow 1 @@ -202,7 +195,7 @@ Login token generated at: - Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop + Qt::AlignmentFlag::AlignLeading|Qt::AlignmentFlag::AlignLeft|Qt::AlignmentFlag::AlignTop @@ -242,7 +235,7 @@ Login token generated at: - Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop + Qt::AlignmentFlag::AlignLeading|Qt::AlignmentFlag::AlignLeft|Qt::AlignmentFlag::AlignTop @@ -252,7 +245,7 @@ Login token generated at: - Qt::Vertical + Qt::Orientation::Vertical @@ -265,7 +258,7 @@ Login token generated at: - +