ShuriZma
/
duckstation
mirror of https://github.com/stenzek/duckstation
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Misc: Add missing error reporting to a couple of WriteBinaryFiles()

This commit is contained in:
Stenzek 2025-01-18 22:49:43 +10:00
parent 227c249d7f
commit 43e7be902c
No known key found for this signature in database
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/core/achievements.cpp
View File

@ -381,9 +381,10 @@ void Achievements::DownloadImage(std::string url, std::string cache_path)
return; return;
} }
if (!FileSystem::WriteBinaryFile(cache_path.c_str(), data.data(), data.size())) Error write_error;
if (!FileSystem::WriteBinaryFile(cache_path.c_str(), data, &write_error))
{ {
ERROR_LOG("Failed to write badge image to '{}'", cache_path); ERROR_LOG("Failed to write badge image to '{}': {}", cache_path, write_error.GetDescription());
return; return;
} }

9
src/duckstation-qt/qthost.cpp
View File

@ -348,12 +348,15 @@ bool QtHost::DownloadFile(QWidget* parent, const QString& title, std::string url
// Directory may not exist. Create it. // Directory may not exist. Create it.
const std::string directory(Path::GetDirectory(path)); const std::string directory(Path::GetDirectory(path));
Error error;
if ((!directory.empty() && !FileSystem::DirectoryExists(directory.c_str()) && if ((!directory.empty() && !FileSystem::DirectoryExists(directory.c_str()) &&
!FileSystem::CreateDirectory(directory.c_str(), true)) || !FileSystem::CreateDirectory(directory.c_str(), true, &error)) ||
!FileSystem::WriteBinaryFile(path, data.data(), data.size())) !FileSystem::WriteBinaryFile(path, data, &error))
{ {
QMessageBox::critical(parent, qApp->translate("QtHost", "Error"), QMessageBox::critical(parent, qApp->translate("QtHost", "Error"),
qApp->translate("QtHost", "Failed to write '%1'.").arg(QString::fromUtf8(path))); qApp->translate("QtHost", "Failed to write '%1':\n%2")
.arg(QString::fromUtf8(path))
.arg(QString::fromUtf8(error.GetDescription())));
return false; return false;
} }