From 42535591bce3c3fb18a365dde25389de5ec9801b Mon Sep 17 00:00:00 2001 From: Stenzek Date: Mon, 9 Dec 2024 20:24:14 +1000 Subject: [PATCH] HTTPDownloader: Log errors on request failure --- src/util/http_downloader.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/util/http_downloader.cpp b/src/util/http_downloader.cpp index 8a97eb8a2..b7fb69b5e 100644 --- a/src/util/http_downloader.cpp +++ b/src/util/http_downloader.cpp @@ -160,8 +160,11 @@ void HTTPDownloader::LockedPollRequests(std::unique_lock& lock) // run callback with lock unheld lock.unlock(); - if (req->status_code != HTTP_STATUS_OK) + if (req->status_code >= 0 && req->status_code != HTTP_STATUS_OK) req->error.SetStringFmt("Request failed with HTTP status code {}", req->status_code); + else if (req->status_code < 0) + DEV_LOG("Request failed with error {}", req->error.GetDescription()); + req->callback(req->status_code, req->error, req->content_type, std::move(req->data)); CloseRequest(req); lock.lock();