From 29331ef67932f2a766672b651191f957ac10d6e5 Mon Sep 17 00:00:00 2001 From: Albert Liu <45282415+ggrtk@users.noreply.github.com> Date: Sun, 10 Jan 2021 20:49:25 -0800 Subject: [PATCH] Qt: Update widget help text --- src/duckstation-qt/advancedsettingswidget.cpp | 2 +- src/duckstation-qt/audiosettingswidget.cpp | 16 ++++++++-------- src/duckstation-qt/consolesettingswidget.cpp | 19 +++++++++++-------- 3 files changed, 20 insertions(+), 17 deletions(-) diff --git a/src/duckstation-qt/advancedsettingswidget.cpp b/src/duckstation-qt/advancedsettingswidget.cpp index b9a327e32..83d21b4cc 100644 --- a/src/duckstation-qt/advancedsettingswidget.cpp +++ b/src/duckstation-qt/advancedsettingswidget.cpp @@ -180,7 +180,7 @@ AdvancedSettingsWidget::AdvancedSettingsWidget(QtHostInterface* host_interface, addIntRangeTweakOption(m_host_interface, m_ui.tweakOptionTable, tr("Minimum Dumped VRAM Write Width"), "TextureReplacements", "DumpVRAMWriteWidthThreshold", 1, VRAM_WIDTH, Settings::DEFAULT_VRAM_WRITE_DUMP_WIDTH_THRESHOLD); - addIntRangeTweakOption(m_host_interface, m_ui.tweakOptionTable, tr("Minimum Dumped VRAM Write Width"), + addIntRangeTweakOption(m_host_interface, m_ui.tweakOptionTable, tr("Minimum Dumped VRAM Write Height"), "TextureReplacements", "DumpVRAMWriteHeightThreshold", 1, VRAM_HEIGHT, Settings::DEFAULT_VRAM_WRITE_DUMP_HEIGHT_THRESHOLD); diff --git a/src/duckstation-qt/audiosettingswidget.cpp b/src/duckstation-qt/audiosettingswidget.cpp index b3f4381d5..c377b9cf4 100644 --- a/src/duckstation-qt/audiosettingswidget.cpp +++ b/src/duckstation-qt/audiosettingswidget.cpp @@ -56,18 +56,17 @@ AudioSettingsWidget::AudioSettingsWidget(QtHostInterface* host_interface, QWidge dialog->registerWidgetHelp( m_ui.startDumpingOnBoot, tr("Start Dumping On Boot"), tr("Unchecked"), tr("Start dumping audio to file as soon as the emulator is started. Mainly useful as a debug option.")); - dialog->registerWidgetHelp(m_ui.volume, tr("Output Volume"), "100", - tr("Controls the volume of the audio played on the host. Values are in percentage.")); - dialog->registerWidgetHelp( - m_ui.fastForwardVolume, tr("Fast Forward Volume"), "100", - tr("Controls the volume of the audio played on the host when fast forwarding. Values are in percentage.")); + dialog->registerWidgetHelp(m_ui.volume, tr("Output Volume"), "100%", + tr("Controls the volume of the audio played on the host.")); + dialog->registerWidgetHelp(m_ui.fastForwardVolume, tr("Fast Forward Volume"), "100%", + tr("Controls the volume of the audio played on the host when fast forwarding.")); dialog->registerWidgetHelp(m_ui.muted, tr("Mute All Sound"), tr("Unchecked"), tr("Prevents the emulator from producing any audible sound.")); dialog->registerWidgetHelp(m_ui.muteCDAudio, tr("Mute CD Audio"), tr("Unchecked"), tr("Forcibly mutes both CD-DA and XA audio from the CD-ROM. Can be used to disable " "background music in some games.")); dialog->registerWidgetHelp( - m_ui.resampling, tr("Resampling"), tr("Unchecked"), + m_ui.resampling, tr("Resampling"), tr("Checked"), tr("When running outside of 100% speed, resamples audio from the target speed instead of dropping frames. Produces " "much nicer fast forward/slowdown audio at a small cost to performance.")); } @@ -86,8 +85,9 @@ void AudioSettingsWidget::updateBufferingLabel() } const float max_latency = AudioStream::GetMaxLatency(HostInterface::AUDIO_SAMPLE_RATE, actual_buffer_size); - m_ui.bufferingLabel->setText( - tr("Maximum latency: %1 frames (%2ms)").arg(actual_buffer_size).arg(max_latency * 1000.0f, 0, 'f', 2)); + m_ui.bufferingLabel->setText(tr("Maximum Latency: %1 frames (%2ms)") + .arg(actual_buffer_size) + .arg(static_cast(max_latency) * 1000.0, 0, 'f', 2)); } void AudioSettingsWidget::updateVolumeLabel() diff --git a/src/duckstation-qt/consolesettingswidget.cpp b/src/duckstation-qt/consolesettingswidget.cpp index 70762b548..00f88434b 100644 --- a/src/duckstation-qt/consolesettingswidget.cpp +++ b/src/duckstation-qt/consolesettingswidget.cpp @@ -64,7 +64,7 @@ ConsoleSettingsWidget::ConsoleSettingsWidget(QtHostInterface* host_interface, QW tr("Loads the game image into RAM. Useful for network paths that may become unreliable during gameplay. In some " "cases also eliminates stutter when games initiate audio track playback.")); dialog->registerWidgetHelp( - m_ui.cdromReadSpeedup, tr("CDROM Read Speedup"), tr("None (Double Speed"), + m_ui.cdromReadSpeedup, tr("CDROM Read Speedup"), tr("None (Double Speed)"), tr("Speeds up CD-ROM reads by the specified factor. Only applies to double-speed reads, and is ignored when audio " "is playing. May improve loading speeds in some games, at the cost of breaking others.")); dialog->registerWidgetHelp( @@ -72,16 +72,19 @@ ConsoleSettingsWidget::ConsoleSettingsWidget(QtHostInterface* host_interface, QW tr("Sets the target emulation speed. It is not guaranteed that this speed will be reached, " "and if not, the emulator will run as fast as it can manage.")); dialog->registerWidgetHelp( - m_ui.fastForwardSpeed, tr("Fast Forward Speed"), "100%", + m_ui.fastForwardSpeed, tr("Fast Forward Speed"), tr("User Preference"), tr("Sets the fast forward speed. This speed will be used when the fast forward hotkey is pressed/toggled.")); dialog->registerWidgetHelp( - m_ui.turboSpeed, tr("Turbo Speed"), "100%", - tr("Sets the turbo speed. This speed will be used when the turbo hotkey is pressed/toggled.")); + m_ui.turboSpeed, tr("Turbo Speed"), tr("User Preference"), + tr("Sets the turbo speed. This speed will be used when the turbo hotkey is pressed/toggled. Turboing will take " + "priority over fast forwarding if both hotkeys are pressed/toggled.")); dialog->registerWidgetHelp( - m_ui.syncToHostRefreshRate, tr("Sync To Host Refresh Rate"), "100%", - tr("Adjusts the emulation speed so the console's refresh rate matches the host's refresh rate, when VSync and " - "Audio Resampling is enabled. This results in the smoothest animations possible, at the cost of potentially " - "increasing the emulation speed by less than 1%.")); + m_ui.syncToHostRefreshRate, tr("Sync To Host Refresh Rate"), tr("Checked"), + tr("Adjusts the emulation speed so the console's refresh rate matches the host's refresh rate when both VSync and " + "Audio Resampling settings are enabled. This results in the smoothest animations possible, at the cost of " + "potentially increasing the emulation speed by less than 1%. Sync To Host Refresh Rate will not take effect if " + "the console's refresh rate is too far from the host's refresh rate. Users with variable refresh rate displays " + "should disable this option.")); m_ui.cpuClockSpeed->setEnabled(m_ui.enableCPUClockSpeedControl->checkState() == Qt::Checked); m_ui.cdromReadSpeedup->setCurrentIndex(m_host_interface->GetIntSettingValue("CDROM", "ReadSpeedup", 1) - 1);