ShuriZma
/
duckstation
mirror of https://github.com/stenzek/duckstation
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Achievements: Mirror whacky rcheevos header handling

This commit is contained in:
Stenzek 2024-09-29 20:38:46 +10:00
parent 6dc4fa5c75
commit 07f410bc6a
No known key found for this signature in database
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/core/achievements.cpp
View File

@ -290,15 +290,16 @@ std::string Achievements::GetGameHash(CDImage* image)
return {}; return {};
} }
// See rcheevos hash.c - rc_hash_psx(). // This is absolutely bonkers silly. Someone decided to hash the file size specified in the executable, plus 2048,
const u32 MAX_HASH_SIZE = 64 * 1024 * 1024; // instead of adding the size of the header. It _should_ be "header.file_size + sizeof(header)". But we have to hack
const u32 hash_size = // around it because who knows how many games are affected by this.
std::min(std::min<u32>(sizeof(header) + header.file_size, MAX_HASH_SIZE), static_cast<u32>(executable_data.size())); // https://github.com/RetroAchievements/rcheevos/blob/b8dd5747a4ed38f556fd776e6f41b131ea16178f/src/rhash/hash.c#L2824
const u32 hash_size = std::min(header.file_size + 2048, static_cast<u32>(executable_data.size()));
MD5Digest digest; MD5Digest digest;
digest.Update(executable_name.c_str(), static_cast<u32>(executable_name.size())); digest.Update(executable_name.c_str(), static_cast<u32>(executable_name.size()));
if (hash_size > 0) if (hash_size > 0)
digest.Update(executable_data); digest.Update(executable_data.data(), hash_size);
u8 hash[16]; u8 hash[16];
digest.Final(hash); digest.Final(hash);