From 50754e205fb031c7e0c05364079a82ebcb807bb3 Mon Sep 17 00:00:00 2001 From: OatmealDome Date: Fri, 5 Jul 2024 17:54:16 -0400 Subject: [PATCH] further explain changes to version constants in ScmRevGen --- Release-Process.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Release-Process.md b/Release-Process.md index 7805c20..6018bb2 100644 --- a/Release-Process.md +++ b/Release-Process.md @@ -13,7 +13,10 @@ Releases can only be created by [core developers](https://github.com/orgs/dolphi * If creating a major release, use the commit that the release should be based on. * If creating a hotfix release, use the tag of the last release. 3. Cherry pick any necessary commits. -4. Update `DOLPHIN_VERSION_MAJOR` and `DOLPHIN_VERSION_MINOR` in `CMake/ScmRevGen.cmake`, and commit the result. +4. Update the version constants in `CMake/ScmRevGen.cmake`, and commit the result. + * Set `DOLPHIN_VERSION_MAJOR` to `YYMM`. + * Set `DOLPHIN_VERSION_MINOR` to the patch number. If creating a hotfix release, use the number corresponding to the patch letter (for example, `a` is `1`, `b` is `2`, etc). Otherwise, set to `0`. + * This field must be set to a number [as CPack does not support non-numerical values in the minor or patch version fields](https://gitlab.kitware.com/cmake/cmake/-/issues/19310). 5. Push the branch to GitHub: `git push -u origin release-prep-YYMM`. 6. Smoke test the produced builds. * The builds can be downloaded at `https://dolphin-emu.org/download/list/release-prep-YYMM/1/`.