72cf2bdb87
Some pieces of code are calling IsRunning because there's some particular action that only makes sense when emulation is running, for instance showing the state of the emulated CPU. IsRunning is appropriate to use for this. Then there are pieces of code that are calling IsRunning because there's some particular thing they must avoid doing e.g. when the CPU thread is running or IOS is running. IsRunning isn't quite appropriate for this. Such code should also be checking for the states Starting and Stopping. Keep in mind that: * When the state is Starting, the state can asynchronously change to Running at any time. * When we try to stop the core, the state gets set to Stopping before we take any action to actually stop things. This commit adds a new method Core::IsUninitialized, and changes all callers of IsRunning and GetState that look to me like they should be changed. |
||
|---|---|---|
| .. | ||
| AdvancedWidget.cpp | ||
| AdvancedWidget.h | ||
| ColorCorrectionConfigWindow.cpp | ||
| ColorCorrectionConfigWindow.h | ||
| EnhancementsWidget.cpp | ||
| EnhancementsWidget.h | ||
| GeneralWidget.cpp | ||
| GeneralWidget.h | ||
| GraphicsWindow.cpp | ||
| GraphicsWindow.h | ||
| HacksWidget.cpp | ||
| HacksWidget.h | ||
| PostProcessingConfigWindow.cpp | ||
| PostProcessingConfigWindow.h | ||