// Copyright 2018 Dolphin Emulator Project // SPDX-License-Identifier: GPL-2.0-or-later #include #include #include #include #include #include #include "Common/CommonTypes.h" #include "Common/FileUtil.h" #include "Core/IOS/FS/FileSystem.h" #include "Core/IOS/IOS.h" #include "UICommon/UICommon.h" using namespace IOS::HLE::FS; constexpr Modes modes{Mode::ReadWrite, Mode::None, Mode::None}; class FileSystemTest : public testing::Test { protected: FileSystemTest() : m_profile_path{File::CreateTempDir()} { if (UserDirectoryCreationFailed()) { return; } UICommon::SetUserDirectory(m_profile_path); m_fs = IOS::HLE::Kernel{}.GetFS(); } virtual ~FileSystemTest() { if (UserDirectoryCreationFailed()) { return; } m_fs.reset(); File::DeleteDirRecursively(m_profile_path); } void SetUp() { if (UserDirectoryCreationFailed()) { FAIL(); } } bool UserDirectoryCreationFailed() const { return m_profile_path.empty(); } std::shared_ptr m_fs; private: std::string m_profile_path; }; TEST(FileSystem, BasicPathValidity) { EXPECT_TRUE(IsValidPath("/")); EXPECT_FALSE(IsValidNonRootPath("/")); EXPECT_TRUE(IsValidNonRootPath("/shared2/sys/SYSCONF")); EXPECT_TRUE(IsValidNonRootPath("/shared2/sys")); EXPECT_TRUE(IsValidNonRootPath("/shared2")); // Paths must start with /. EXPECT_FALSE(IsValidNonRootPath("\\test")); // Paths must not end with /. EXPECT_FALSE(IsValidNonRootPath("/shared2/sys/")); // Paths must not be longer than 64 characters. EXPECT_FALSE(IsValidPath( "/abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz")); } TEST(FileSystem, PathSplitting) { SplitPathResult result; result = {"/shared1", "00000042.app"}; EXPECT_EQ(SplitPathAndBasename("/shared1/00000042.app"), result); result = {"/shared2/sys", "SYSCONF"}; EXPECT_EQ(SplitPathAndBasename("/shared2/sys/SYSCONF"), result); result = {"/shared2", "sys"}; EXPECT_EQ(SplitPathAndBasename("/shared2/sys"), result); result = {"/", "shared2"}; EXPECT_EQ(SplitPathAndBasename("/shared2"), result); } TEST_F(FileSystemTest, EssentialDirectories) { for (const std::string& path : {"/sys", "/ticket", "/title", "/shared1", "/shared2", "/tmp", "/import", "/meta"}) { EXPECT_TRUE(m_fs->ReadDirectory(Uid{0}, Gid{0}, path).Succeeded()) << path; } } TEST_F(FileSystemTest, CreateFile) { const std::string PATH = "/tmp/f"; constexpr u8 ArbitraryAttribute = 0xE1; ASSERT_EQ(m_fs->CreateFile(Uid{0}, Gid{0}, PATH, ArbitraryAttribute, modes), ResultCode::Success); const Result stats = m_fs->GetMetadata(Uid{0}, Gid{0}, PATH); ASSERT_TRUE(stats.Succeeded()); EXPECT_TRUE(stats->is_file); EXPECT_EQ(stats->size, 0u); EXPECT_EQ(stats->uid, 0u); EXPECT_EQ(stats->gid, 0); EXPECT_EQ(stats->modes, modes); EXPECT_EQ(stats->attribute, ArbitraryAttribute); ASSERT_EQ(m_fs->CreateFile(Uid{0}, Gid{0}, PATH, 0, modes), ResultCode::AlreadyExists); const Result> tmp_files = m_fs->ReadDirectory(Uid{0}, Gid{0}, "/tmp"); ASSERT_TRUE(tmp_files.Succeeded()); EXPECT_EQ(std::count(tmp_files->begin(), tmp_files->end(), "f"), 1u); // Test invalid paths // Unprintable characters EXPECT_EQ(m_fs->CreateFile(Uid{0}, Gid{0}, "/tmp/tes\1t", 0, modes), ResultCode::Invalid); EXPECT_EQ(m_fs->CreateFile(Uid{0}, Gid{0}, "/tmp/te\x7fst", 0, modes), ResultCode::Invalid); // Paths with too many components are not rejected for files. EXPECT_EQ(m_fs->CreateFile(Uid{0}, Gid{0}, "/1/2/3/4/5/6/7/8/9", 0, modes), ResultCode::NotFound); } TEST_F(FileSystemTest, CreateDirectory) { const std::string PATH = "/tmp/d"; constexpr u8 ArbitraryAttribute = 0x20; ASSERT_EQ(m_fs->CreateDirectory(Uid{0}, Gid{0}, PATH, ArbitraryAttribute, modes), ResultCode::Success); const Result stats = m_fs->GetMetadata(Uid{0}, Gid{0}, PATH); ASSERT_TRUE(stats.Succeeded()); EXPECT_FALSE(stats->is_file); EXPECT_EQ(stats->uid, 0u); EXPECT_EQ(stats->gid, 0); EXPECT_EQ(stats->modes, modes); EXPECT_EQ(stats->attribute, ArbitraryAttribute); const Result> children = m_fs->ReadDirectory(Uid{0}, Gid{0}, PATH); ASSERT_TRUE(children.Succeeded()); EXPECT_TRUE(children->empty()); EXPECT_EQ(m_fs->CreateDirectory(Uid{0}, Gid{0}, PATH, 0, modes), ResultCode::AlreadyExists); // Paths with too many components should be rejected. EXPECT_EQ(m_fs->CreateDirectory(Uid{0}, Gid{0}, "/1/2/3/4/5/6/7/8/9", 0, modes), ResultCode::TooManyPathComponents); } TEST_F(FileSystemTest, Delete) { EXPECT_TRUE(m_fs->ReadDirectory(Uid{0}, Gid{0}, "/tmp").Succeeded()); EXPECT_EQ(m_fs->Delete(Uid{0}, Gid{0}, "/tmp"), ResultCode::Success); EXPECT_EQ(m_fs->ReadDirectory(Uid{0}, Gid{0}, "/tmp").Error(), ResultCode::NotFound); // Test recursive directory deletion. ASSERT_EQ(m_fs->CreateDirectory(Uid{0}, Gid{0}, "/sys/1", 0, modes), ResultCode::Success); ASSERT_EQ(m_fs->CreateDirectory(Uid{0}, Gid{0}, "/sys/1/2", 0, modes), ResultCode::Success); ASSERT_EQ(m_fs->CreateFile(Uid{0}, Gid{0}, "/sys/1/2/3", 0, modes), ResultCode::Success); ASSERT_EQ(m_fs->CreateFile(Uid{0}, Gid{0}, "/sys/1/2/4", 0, modes), ResultCode::Success); // Leave a file open. Deletion should fail while the file is in use. auto handle = std::make_optional(m_fs->OpenFile(Uid{0}, Gid{0}, "/sys/1/2/3", Mode::Read)); ASSERT_TRUE(handle->Succeeded()); EXPECT_EQ(m_fs->Delete(Uid{0}, Gid{0}, "/sys/1/2/3"), ResultCode::InUse); // A directory that contains a file that is in use is considered to be in use, // so this should fail too. EXPECT_EQ(m_fs->Delete(Uid{0}, Gid{0}, "/sys/1"), ResultCode::InUse); // With the handle closed, both of these should work: handle.reset(); EXPECT_EQ(m_fs->Delete(Uid{0}, Gid{0}, "/sys/1/2/3"), ResultCode::Success); EXPECT_EQ(m_fs->Delete(Uid{0}, Gid{0}, "/sys/1"), ResultCode::Success); } TEST_F(FileSystemTest, Rename) { EXPECT_TRUE(m_fs->ReadDirectory(Uid{0}, Gid{0}, "/tmp").Succeeded()); EXPECT_EQ(m_fs->Rename(Uid{0}, Gid{0}, "/tmp", "/test"), ResultCode::Success); EXPECT_EQ(m_fs->ReadDirectory(Uid{0}, Gid{0}, "/tmp").Error(), ResultCode::NotFound); EXPECT_TRUE(m_fs->ReadDirectory(Uid{0}, Gid{0}, "/test").Succeeded()); // Rename /test back to /tmp. EXPECT_EQ(m_fs->Rename(Uid{0}, Gid{0}, "/test", "/tmp"), ResultCode::Success); // Create a file called /tmp/f1, and rename it to /tmp/f2. // This should not work; file name changes are not allowed for files. ASSERT_EQ(m_fs->CreateFile(Uid{0}, Gid{0}, "/tmp/f1", 0, modes), ResultCode::Success); EXPECT_EQ(m_fs->Rename(Uid{0}, Gid{0}, "/tmp/f1", "/tmp/f2"), ResultCode::Invalid); } TEST_F(FileSystemTest, RenameWithExistingTargetDirectory) { // Test directory -> existing, non-empty directory. // IOS's FS sysmodule is not POSIX compliant and will remove the existing directory // if it exists, even when there are files in it. ASSERT_EQ(m_fs->CreateDirectory(Uid{0}, Gid{0}, "/tmp/d", 0, modes), ResultCode::Success); ASSERT_EQ(m_fs->CreateDirectory(Uid{0}, Gid{0}, "/tmp/d2", 0, modes), ResultCode::Success); ASSERT_EQ(m_fs->CreateFile(Uid{0}, Gid{0}, "/tmp/d2/file", 0, modes), ResultCode::Success); EXPECT_EQ(m_fs->Rename(Uid{0}, Gid{0}, "/tmp/d", "/tmp/d2"), ResultCode::Success); EXPECT_EQ(m_fs->ReadDirectory(Uid{0}, Gid{0}, "/tmp/d").Error(), ResultCode::NotFound); const Result> children = m_fs->ReadDirectory(Uid{0}, Gid{0}, "/tmp/d2"); ASSERT_TRUE(children.Succeeded()); EXPECT_TRUE(children->empty()); } TEST_F(FileSystemTest, RenameWithExistingTargetFile) { const std::string source_path = "/sys/f2"; const std::string dest_path = "/tmp/f2"; // Create the test source file and write some data (so that we can check its size later on). ASSERT_EQ(m_fs->CreateFile(Uid{0}, Gid{0}, source_path, 0, modes), ResultCode::Success); const std::vector TEST_DATA{{0, 1, 2, 3, 4, 5, 6, 7, 8, 9}}; std::vector read_buffer(TEST_DATA.size()); { const Result file = m_fs->OpenFile(Uid{0}, Gid{0}, source_path, Mode::ReadWrite); ASSERT_TRUE(file.Succeeded()); ASSERT_TRUE(file->Write(TEST_DATA.data(), TEST_DATA.size()).Succeeded()); } // Create the test target file and leave it empty. ASSERT_EQ(m_fs->CreateFile(Uid{0}, Gid{0}, dest_path, 0, modes), ResultCode::Success); // Rename /sys/f2 to /tmp/f2 and check that f1 replaced f2. EXPECT_EQ(m_fs->Rename(Uid{0}, Gid{0}, source_path, dest_path), ResultCode::Success); ASSERT_FALSE(m_fs->GetMetadata(Uid{0}, Gid{0}, source_path).Succeeded()); EXPECT_EQ(m_fs->GetMetadata(Uid{0}, Gid{0}, source_path).Error(), ResultCode::NotFound); const Result metadata = m_fs->GetMetadata(Uid{0}, Gid{0}, dest_path); ASSERT_TRUE(metadata.Succeeded()); EXPECT_TRUE(metadata->is_file); EXPECT_EQ(metadata->size, TEST_DATA.size()); } TEST_F(FileSystemTest, GetDirectoryStats) { auto check_stats = [this](u32 clusters, u32 inodes) { const Result stats = m_fs->GetDirectoryStats("/tmp"); ASSERT_TRUE(stats.Succeeded()); EXPECT_EQ(stats->used_clusters, clusters); EXPECT_EQ(stats->used_inodes, inodes); }; check_stats(0u, 1u); EXPECT_EQ(m_fs->CreateFile(Uid{0}, Gid{0}, "/tmp/file", 0, modes), ResultCode::Success); // Still no clusters (because the file is empty), but 2 inodes now. check_stats(0u, 2u); { const Result file = m_fs->OpenFile(Uid{0}, Gid{0}, "/tmp/file", Mode::Write); file->Write(std::vector(20).data(), 20); } // The file should now take up one cluster. // TODO: uncomment after the FS code is fixed. // check_stats(1u, 2u); } // Files need to be explicitly created using CreateFile or CreateDirectory. // Automatically creating them on first use would be a bug. TEST_F(FileSystemTest, NonExistingFiles) { const Result metadata = m_fs->GetMetadata(Uid{0}, Gid{0}, "/tmp/foo"); ASSERT_FALSE(metadata.Succeeded()); EXPECT_EQ(metadata.Error(), ResultCode::NotFound); const Result file = m_fs->OpenFile(Uid{0}, Gid{0}, "/tmp/foo", Mode::Read); ASSERT_FALSE(file.Succeeded()); EXPECT_EQ(file.Error(), ResultCode::NotFound); const Result> children = m_fs->ReadDirectory(Uid{0}, Gid{0}, "/foo"); ASSERT_FALSE(children.Succeeded()); EXPECT_EQ(children.Error(), ResultCode::NotFound); } TEST_F(FileSystemTest, Seek) { const std::vector TEST_DATA(10); ASSERT_EQ(m_fs->CreateFile(Uid{0}, Gid{0}, "/tmp/f", 0, modes), ResultCode::Success); const Result file = m_fs->OpenFile(Uid{0}, Gid{0}, "/tmp/f", Mode::ReadWrite); ASSERT_TRUE(file.Succeeded()); // An empty file should have a size of exactly 0 bytes. EXPECT_EQ(file->GetStatus()->size, 0u); // The file position should be set to the start right after an open. EXPECT_EQ(file->GetStatus()->offset, 0u); // Write some dummy data. ASSERT_TRUE(file->Write(TEST_DATA.data(), TEST_DATA.size()).Succeeded()); EXPECT_EQ(file->GetStatus()->size, TEST_DATA.size()); EXPECT_EQ(file->GetStatus()->offset, TEST_DATA.size()); auto seek_and_check = [&file](u32 offset, SeekMode mode, u32 expected_position) { const Result new_offset = file->Seek(offset, mode); ASSERT_TRUE(new_offset.Succeeded()); EXPECT_EQ(*new_offset, expected_position); EXPECT_EQ(file->GetStatus()->offset, expected_position); }; seek_and_check(0, SeekMode::Set, 0); seek_and_check(5, SeekMode::Set, 5); seek_and_check(0, SeekMode::Current, 5); seek_and_check(2, SeekMode::Current, 7); seek_and_check(0, SeekMode::End, 10); // Test past-EOF seeks. const Result new_position = file->Seek(11, SeekMode::Set); ASSERT_FALSE(new_position.Succeeded()); EXPECT_EQ(new_position.Error(), ResultCode::Invalid); } TEST_F(FileSystemTest, WriteAndSimpleReadback) { const std::vector TEST_DATA{{0, 1, 2, 3, 4, 5, 6, 7, 8, 9}}; std::vector read_buffer(TEST_DATA.size()); ASSERT_EQ(m_fs->CreateFile(Uid{0}, Gid{0}, "/tmp/f", 0, modes), ResultCode::Success); const Result file = m_fs->OpenFile(Uid{0}, Gid{0}, "/tmp/f", Mode::ReadWrite); ASSERT_TRUE(file.Succeeded()); // Write some test data. ASSERT_TRUE(file->Write(TEST_DATA.data(), TEST_DATA.size()).Succeeded()); // Now read it back and make sure it is identical. ASSERT_TRUE(file->Seek(0, SeekMode::Set).Succeeded()); ASSERT_TRUE(file->Read(read_buffer.data(), read_buffer.size()).Succeeded()); EXPECT_EQ(TEST_DATA, read_buffer); } TEST_F(FileSystemTest, WriteAndRead) { const std::vector TEST_DATA{{0xf, 1, 2, 3, 4, 5, 6, 7, 8, 9}}; const u32 TEST_DATA_SIZE = static_cast(TEST_DATA.size()); std::vector buffer(TEST_DATA_SIZE); ASSERT_EQ(m_fs->CreateFile(Uid{0}, Gid{0}, "/tmp/f", 0, modes), ResultCode::Success); Result tmp_handle = m_fs->OpenFile(Uid{0}, Gid{0}, "/tmp/f", Mode::ReadWrite); ASSERT_TRUE(tmp_handle.Succeeded()); const Fd fd = tmp_handle->Release(); // Try to read from an empty file. This should do nothing. // See https://github.com/dolphin-emu/dolphin/pull/4942 Result read_result = m_fs->ReadBytesFromFile(fd, buffer.data(), TEST_DATA_SIZE); EXPECT_TRUE(read_result.Succeeded()); EXPECT_EQ(*read_result, 0u); EXPECT_EQ(m_fs->GetFileStatus(fd)->offset, 0u); ASSERT_TRUE(m_fs->WriteBytesToFile(fd, TEST_DATA.data(), TEST_DATA_SIZE).Succeeded()); EXPECT_EQ(m_fs->GetFileStatus(fd)->offset, TEST_DATA.size()); // Try to read past EOF while we are at the end of the file. This should do nothing too. read_result = m_fs->ReadBytesFromFile(fd, buffer.data(), TEST_DATA_SIZE); EXPECT_TRUE(read_result.Succeeded()); EXPECT_EQ(*read_result, 0u); EXPECT_EQ(m_fs->GetFileStatus(fd)->offset, TEST_DATA.size()); // Go back to the start and try to read past EOF. This should read the entire file until EOF. ASSERT_TRUE(m_fs->SeekFile(fd, 0, SeekMode::Set).Succeeded()); const u32 LARGER_TEST_DATA_SIZE = TEST_DATA_SIZE + 10; std::vector larger_buffer(LARGER_TEST_DATA_SIZE); read_result = m_fs->ReadBytesFromFile(fd, larger_buffer.data(), LARGER_TEST_DATA_SIZE); EXPECT_TRUE(read_result.Succeeded()); EXPECT_EQ(*read_result, TEST_DATA.size()); EXPECT_EQ(m_fs->GetFileStatus(fd)->offset, TEST_DATA.size()); } TEST_F(FileSystemTest, MultipleHandles) { ASSERT_EQ(m_fs->CreateFile(Uid{0}, Gid{0}, "/tmp/f", 0, modes), ResultCode::Success); { const Result file = m_fs->OpenFile(Uid{0}, Gid{0}, "/tmp/f", Mode::ReadWrite); ASSERT_TRUE(file.Succeeded()); // Fill it with 10 zeroes. ASSERT_TRUE(file->Write(std::vector(10).data(), 10).Succeeded()); } const Result file1 = m_fs->OpenFile(Uid{0}, Gid{0}, "/tmp/f", Mode::ReadWrite); const Result file2 = m_fs->OpenFile(Uid{0}, Gid{0}, "/tmp/f", Mode::ReadWrite); ASSERT_TRUE(file1.Succeeded()); ASSERT_TRUE(file2.Succeeded()); // Write some test data using one handle and make sure the data is seen by the other handle // (see issue 2917, 5232 and 8702 and https://github.com/dolphin-emu/dolphin/pull/2649). // Also make sure the file offsets are independent for each handle. const std::vector TEST_DATA{{0, 1, 2, 3, 4, 5, 6, 7, 8, 9}}; EXPECT_EQ(file1->GetStatus()->offset, 0u); ASSERT_TRUE(file1->Write(TEST_DATA.data(), TEST_DATA.size()).Succeeded()); EXPECT_EQ(file1->GetStatus()->offset, 10u); std::vector read_buffer(TEST_DATA.size()); EXPECT_EQ(file2->GetStatus()->offset, 0u); ASSERT_TRUE(file2->Read(read_buffer.data(), read_buffer.size()).Succeeded()); EXPECT_EQ(file2->GetStatus()->offset, 10u); EXPECT_EQ(TEST_DATA, read_buffer); } // ReadDirectory is used by official titles to determine whether a path is a file. // If it is not a file, ResultCode::Invalid must be returned. TEST_F(FileSystemTest, ReadDirectoryOnFile) { ASSERT_EQ(m_fs->CreateFile(Uid{0}, Gid{0}, "/tmp/f", 0, modes), ResultCode::Success); const Result> result = m_fs->ReadDirectory(Uid{0}, Gid{0}, "/tmp/f"); ASSERT_FALSE(result.Succeeded()); EXPECT_EQ(result.Error(), ResultCode::Invalid); } TEST_F(FileSystemTest, ReadDirectoryOrdering) { ASSERT_EQ(m_fs->CreateDirectory(Uid{0}, Gid{0}, "/tmp/o", 0, modes), ResultCode::Success); // Randomly generated file names in no particular order. const std::array file_names{{ "Rkj62lGwHp", "XGDQTDJMea", "1z5M43WeFw", "YAY39VuMRd", "hxJ86nkoBX", }}; // Create the files. for (const auto& name : file_names) ASSERT_EQ(m_fs->CreateFile(Uid{0}, Gid{0}, "/tmp/o/" + name, 0, modes), ResultCode::Success); // Verify that ReadDirectory returns a file list that is ordered by descending creation date // (issue 10234). const Result> result = m_fs->ReadDirectory(Uid{0}, Gid{0}, "/tmp/o"); ASSERT_TRUE(result.Succeeded()); ASSERT_EQ(result->size(), file_names.size()); EXPECT_TRUE(std::equal(result->begin(), result->end(), file_names.rbegin())); } TEST_F(FileSystemTest, CreateFullPath) { ASSERT_EQ(m_fs->CreateFullPath(Uid{0}, Gid{0}, "/tmp/a/b/c/d", 0, modes), ResultCode::Success); // Parent directories should be created by CreateFullPath. for (const std::string& path : {"/tmp", "/tmp/a", "/tmp/a/b", "/tmp/a/b/c"}) EXPECT_TRUE(m_fs->ReadDirectory(Uid{0}, Gid{0}, path).Succeeded()); // If parent directories already exist, the call should still succeed. EXPECT_EQ(m_fs->CreateFullPath(Uid{0}, Gid{0}, "/tmp/a/b/c/d", 0, modes), ResultCode::Success); // If parent directories already exist and are owned by a different user, // CreateFullPath should still succeed. // See https://github.com/dolphin-emu/dolphin/pull/8593 EXPECT_EQ(m_fs->CreateFullPath(Uid{0x1000}, Gid{1}, "/shared2/wc24/mbox/Readme.txt", 0, modes), ResultCode::Success); }