ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
35,684 Commits 5 Branches 11 Tags 1.3 GiB
Commit Graph

30524 Commits

Author SHA1 Message Date
JMC47 ca064b55fe
Merge pull request #10111 from JosJuice/networkwidget-hidden 
DolphinQt: Don't update NetworkWidget when hidden
 2021-09-18 09:33:45 -04:00
JosJuice 0a973ddcbb DolphinQt: Don't update NetworkWidget when hidden 
Like 92a655c but for NetworkWidget (which was added later).
 2021-09-18 14:41:11 +02:00
Scott Mansell ce80a96aee BPStructs: ensure side effects are same 
Missed this side effect when fixing crash in Mario Kart Wii wifi
 2021-09-18 23:58:24 +12:00
JosJuice e5ed9ee920 Core: Remove s_request_refresh_info 
It's only used for frame stepping. We can use s_frame_step instead.
 2021-09-18 13:39:38 +02:00
JosJuice a3ce8d61fd Android: Show confirmation dialog for clearing game settings 2021-09-18 12:35:46 +02:00
OatmealDome 7e8f5208fe VulkanContext: Disable subgroup reduction on macOS with AMD GPUs 2021-09-16 23:32:10 -04:00
Scott Mansell 7c7609f5b9 BPStructs: Ignore malformed efb copies 2021-09-17 12:42:23 +12:00
Léo Lam 7379450633
Merge pull request #10092 from JosJuice/android-cheats 
Android: Add cheat GUI
 2021-09-16 19:21:33 +02:00
JosJuice 0ca4c6dbd4 Android: Add save button to cheats activity 
By request. Matches the settings activity.
 2021-09-16 18:48:40 +02:00
JosJuice ffa25c4cf5 Android: Allow $ line when entering cheat code 
Port of cda442d.
 2021-09-16 18:48:40 +02:00
JosJuice 53ae1a0725 Android: Add Gecko code downloading 2021-09-16 18:48:39 +02:00
JosJuice 47efd3317d Android: Fix CheatsActivity d-pad navigation 
Special shoutout to Android for not having RTL compatible
variants of nextFocusRight and nextFocusLeft.

Ideally we would have some way to block the user from using
the d-pad to switch between the two panes when in portrait mode,
or make the list pane act as if it's to the left of the details
pane rather than the right when the details pane is open, but I
don't know of a good way to do this. SlidingPaneLayout doesn't
really seem to have been implemented with d-pad navigation in mind.
Thankfully, landscape is the most important use case for gamepads.
 2021-09-16 18:48:39 +02:00
JosJuice 215492152c Android: Show warning when Enable Cheats is off 2021-09-16 18:48:39 +02:00
JosJuice 1470dfcf81 Android: Add the ability to delete cheats 2021-09-16 18:48:39 +02:00
JosJuice 404eb13e2f Android: Add the ability to add cheats 2021-09-16 18:48:39 +02:00
JosJuice 6934b9a21d Android: Add headers to cheat list 2021-09-16 18:48:38 +02:00
JosJuice 109aef4b81 Android: Scroll to field with error when error occurs 2021-09-16 18:48:38 +02:00
JosJuice e299be1d85 Android: Add creator and notes fields for Gecko codes 2021-09-16 18:48:38 +02:00
JosJuice 883a9f8a99 Android: Allow viewing/editing the actual codes 2021-09-16 18:48:38 +02:00
JosJuice fc6c31c3db Android: Update cheat list when a cheat is edited 
The way I'm implementing events using LiveData feels rather
unorthodox, but I'm not aware of anything in the Android framework
that would let me do it in a better way... One option I did
consider was wrapping the cheat lists in LiveData and observing
those, but then CheatsAdapter wouldn't know which cheat had
changed, only that there was some kind of change to the list,
necessitating the use of the not recommended notifyDataSetChanged.
 2021-09-16 16:46:50 +02:00
JosJuice 43dcbf33ad Android: Add edit button for cheats 2021-09-16 16:46:49 +02:00
JosJuice a303b4bc98 Android: Programmatically open/close cheat details 
Only has an effect when using a narrow screen.
 2021-09-16 16:46:49 +02:00
JosJuice 95879c2e76 Android: Add details view for cheats 
The details view only contains the name of the cheat for now.
 2021-09-16 16:46:49 +02:00
JosJuice 93a1271386 Android: Add checkboxes for toggling cheats enabled 2021-09-16 16:46:49 +02:00
JosJuice 67a8855d9a Android: Add "Enable Cheats" setting to GUI 2021-09-16 16:46:49 +02:00
JosJuice 4d609c769f Android: Implement basic read-only cheats list 2021-09-16 16:46:48 +02:00
JosJuice ee3a5a4a81 Android: Create CheatsActivity 2021-09-16 16:46:48 +02:00
Admiral H. Curtiss bd92c29ef5
Core/CheatSearch: Avoid length underflow on new search. 2021-09-16 08:13:02 +02:00
Admiral H. Curtiss c40e8ee3a8
Qt/CheatsManager: Show disabled AR and Gecko tabs when no game is running. 2021-09-16 08:01:40 +02:00
Admiral H. Curtiss dd9047f7c5
Qt/GeckoCodeWidget: Disable functionality if no game id is given. 2021-09-16 08:01:40 +02:00
Admiral H. Curtiss a4b1ea3d70
Qt/ARCodeWidget: Disable functionality if no game id is given. 2021-09-16 08:01:40 +02:00
Admiral H. Curtiss aa2d089d1b
Qt/MenuBar: Allow opening Cheats Manager regardless of emulation state and configuration. 2021-09-16 08:01:26 +02:00
Admiral H. Curtiss aee6e45386
Qt/CheatsManager: Let the 'Configure Dolphin' button shown in the Cheats Manager when Cheats are disabled actually open the settings. 2021-09-16 08:01:12 +02:00
JMC47 4d1bd54917
Merge pull request #10095 from phire/fix-out-of-range-efb 
BPStructs: fix out-of-range EFB copy clamping
 2021-09-15 13:26:23 -04:00
Admiral H. Curtiss 55397b6d52 DolphinQt: Rewrite cheat search GUI. 2021-09-15 19:05:49 +02:00
Admiral H. Curtiss f3346262d2 Core/CheatSearch: Implement cheat searching functionality. 2021-09-15 19:05:48 +02:00
Lioncash 2b9c65967e NetPlayClient: Change return value of OnData() to void 
In all usage cases, the return value isn't utilized.
 2021-09-15 11:31:32 -04:00
Lioncash ae714b25ba NetPlayClient: Split out OnData() 
Over time OnData() has become a huge function-long case statement that
attempts to manage numerous packet-related behaviors, which makes it a
little difficult to reliably ensure certain handling doesn't interfere
with another case's. It's also mildly annoying to navigate due to its
size.

To make it a little easier to read and find the specific behavior, we
can break the relevant pieces of code out into their own functions.
 2021-09-15 11:31:28 -04:00
Léo Lam 94cfbfc49d
Merge pull request #10099 from AdmiralCurtiss/directoryblob-read-between-files 
DiscIO/DirectoryBlob: Handle reads between files.
 2021-09-15 14:38:37 +02:00
Léo Lam 94e9751dfe
Merge pull request #10100 from Pokechu22/no-wglShareLists 
GLInterface: Remove unneeded wglShareLists call
 2021-09-15 14:37:19 +02:00
Léo Lam 111c36e6cd
Merge pull request #10101 from lioncash/kb 
SI_DeviceKeyboard: Shorten MapKeys()
 2021-09-15 13:24:05 +02:00
Lioncash 7c909a73de SI_DeviceKeyboard: Shorten MapKeys() 
We can wrap this logic into a lambda to avoid copy-pasted checking of
the over 400+ lines of code.
 2021-09-15 01:58:02 -04:00
Scott Mansell eb8bfabdfd BPStructs: make copy width/height const 2021-09-15 11:54:40 +12:00
Léo Lam 15ec7bd546
Merge pull request #10097 from JosJuice/jitarm64-w0-clobber 
JitArm64: Fix fresx/frsqrtex unlocking W0 too early
 2021-09-14 23:51:24 +02:00
Pokechu22 b8f4a4ae44 GLInterface: Remove unneeded wglShareLists call 
When RenderDoc is attached, wglShareLists fails for some reason (see baldurk/renderdoc#2361).  wglCreateContextAttribsARB has a parameter for the share context, so there's no reason to use a separate wglShareLists call.

Co-authored-by: baldurk <baldurk@baldurk.org>
 2021-09-14 10:55:33 -07:00
Léo Lam 819a0a69ff
Merge pull request #10076 from lioncash/sibf 
SI: Migrate bitfields to Common::BitField
 2021-09-14 19:10:39 +02:00
Admiral H. Curtiss f76aaf65f6 Common/FileUtil: Strip trailing path separator in ScanDirectoryTree(). 2021-09-14 17:39:38 +02:00
Scott Mansell 37b80e2170 BPStructs: fix out-of-range EFB copy clamping 
Previous code from #7950 only clamps correctly when the efb copies
left and top coordinates are (0, 0)

Now we should handle all situations.

Spyro: A hero's tail is an example of a game that does an oversized
EFB copy with a non-zero origin.
 2021-09-15 02:31:38 +12:00
Admiral H. Curtiss 06d41c53ce DiscIO/DirectoryBlob: Handle reads between files. 2021-09-14 07:09:55 +02:00
JosJuice 74f2acd83b JitArm64: Move fresx/frsqrtex RW calls earlier 
If W0 is locked when fpr.RW is called, the indirectly called
ConvertSingleToDoubleLower may need to emit a push+pop, so it's
better for fresx/frsqrtex to call RW before locking W0 than after.
 2021-09-13 19:27:16 +02:00
JosJuice 1c4155f800 JitArm64: Fix fresx/frsqrtex unlocking W0 too early 
fpr.RW may clobber GPRs that are not locked.
Fixes https://bugs.dolphin-emu.org/issues/12656.
 2021-09-13 19:03:43 +02:00
Lioncash d00e7d5a75 SI: Collapse interrupt generation check in UpdateInterrupts() 
We can simplify this by storing the result of the test into a variable
instead.
 2021-09-13 11:25:03 -04:00
Lioncash ca24c32cbf SI: Eliminate trivial sign conversion cases in RegisterMMIO() 
Previously differently signed types were being used to create addresses
and bit offsets.
 2021-09-13 11:24:59 -04:00
Léo Lam ee863e6722
Merge pull request #10014 from OatmealDome/wiimote-disconnect-crash 
WiimoteReal: Fix Wiimote disconnection causing Dolphin to crash on macOS
 2021-09-13 15:26:02 +02:00
Léo Lam 5f2a8d98fb
Merge pull request #10093 from JosJuice/revert-revert-10025 
Revert "Revert "DolphinQt: Minor consistency fixes for the Settings window""
 2021-09-13 14:54:01 +02:00
JMC47 05f86b9f5b
Merge pull request #10012 from Pokechu22/thps4-green-sky 
UberShaderVertex: Fix Tony Hawk Pro Skater 4
 2021-09-09 17:58:35 -04:00
JosJuice 5ea121eeb5 Revert "Revert "DolphinQt: Minor consistency fixes for the Settings window"" 
This reverts commit e376a985e4.

A beta build has been released now, so there's no reason to keep
it reverted anymore.
 2021-09-08 22:09:19 +02:00
JosJuice b4787cdbd3
Merge pull request #10077 from lioncash/dvdbf 
DVDInterface: Migrate bitfields over to Common::BitField
 2021-09-08 21:37:09 +02:00
JosJuice 52304df943
Merge pull request #10011 from JosJuice/android-cheats-preparation 
Split out code for serializing/deserializing cheat lines
 2021-09-08 21:36:56 +02:00
JosJuice 2a22367211
Merge pull request #10056 from lioncash/qtloc 
DolphinQt: Minor localization changes
 2021-09-08 21:36:46 +02:00
Mai M 059794b551
Merge pull request #10087 from JosJuice/jitarm64-psq-caller-saved 
JitArm64: Move psq_stXX GetCallerSavedUsed calls later
 2021-09-08 04:00:43 -04:00
Mai M 8809d8eb61
Merge pull request #10089 from AdmiralCurtiss/jit-cache-valid-block-clear 
PowerPC/JitCache: Clear valid_block bits for long invalidations.
 2021-09-08 04:00:23 -04:00
Pokechu22 52c82733f6 Use custom isnan implementation to avoid HLSL optimizer issues 
This adjusts the NaN replacement logic introduced in #9928 to work around the HLSL compiler optimizing away calls to isnan, which caused that functionality to not work with ubershaders on D3D11 and D3D12 (it did work with specialized shaders, despite a warning being logged for both; that warning is also now gone).  Note that the `D3DCOMPILE_IEEE_STRICTNESS` flag did not solve this issue, despite the warning suggesting that it might.

Suggested by @kayru and @jamiehayes.
 2021-09-07 19:04:40 -07:00
Admiral H. Curtiss 34992f52c7 PowerPC/JitCache: Clear valid_block bits for long invalidations. 2021-09-07 23:14:20 +02:00
JosJuice 23f6fdebcb Revert "JitArm64: Indexed paired loadstores workaround, attempt 2" 
This reverts commit 3071a1d13b.
 2021-09-05 11:45:40 +02:00
JosJuice 743de44f03 JitArm64: Move psq_stXX GetCallerSavedUsed calls later 
This is a proper fix for the issue that 3071a1d was a workaround for.
It wasn't some kind of bug in the register cache that had laid dormant,
it was a simple mistake made in b24b79e.
 2021-09-05 11:42:07 +02:00
Mai M 282fda1530
Merge pull request #10086 from JosJuice/jitarm64-w0 
JitArm64: Fix W0 being present twice in register cache
 2021-09-04 21:14:40 -04:00
JosJuice ea1210773c JitArm64: Fix W0 being present twice in register cache 
Fixes a regression from ecf86bb.

The GPR allocation_order is initialized with only 28 elements,
so the 29th element ends up getting zero initialized.
Very sneaky bug...
 2021-09-04 12:48:45 +02:00
JosJuice 156ccdb805
Merge pull request #10082 from lioncash/texenum 
BPMemory: Make ZTexOp enum an enum class
 2021-09-02 08:14:05 +02:00
Lioncash f36fd5fa39 BPMemory: Make ZTexOp enum an enum class 
Avoids placing generic names in the surrounding namespace.
 2021-09-01 18:23:22 -04:00
Lioncash 269b7a2166 MemoryInterface: Eliminate trivial sign conversion cases 
We can just use unsigned loop variables instead of signed ones.
 2021-09-01 06:39:06 -04:00
Lioncash 163b24833d MemoryInterface: Migrate bitfields over to Common::BitField 2021-09-01 06:36:25 -04:00
Pokechu22 e9c6c13886 msbuild: Move DivUtils to DolphinLib.props 
It was accidentally put into the main DolphinLib.vcxproj in #9566.
 2021-08-31 22:48:07 -07:00
Lioncash 15566048f0 DVDInterface: Migrate bitfields over to Common::BitField 2021-08-31 17:27:43 -04:00
Lioncash e68b9de62c SI: Migrate bitfields to Common::BitField 2021-08-31 16:26:07 -04:00
Léo Lam 32c7524f4d
Merge pull request #10021 from Dentomologist/make_windows_tabbar_scroll_buttons_opaque 
DolphinQt: Make Windows tab bar scroll buttons opaque
 2021-08-31 19:18:03 +02:00
Léo Lam c3dadd140b
Merge pull request #10074 from lioncash/pte 
MMU: Tidy up PTE-related code
 2021-08-31 19:17:08 +02:00
Léo Lam ef358a122a
Merge pull request #10075 from lioncash/memcheck 
MMU: Don't truncate 64-bit values when calling Memcheck()
 2021-08-31 19:06:33 +02:00
Lioncash ed0aa5928f Gekko: Remove unused UReg_PTE 
PTEs are only ever operated on in terms of their halves in our code
currently, so this can be removed.
 2021-08-31 12:18:31 -04:00
Lioncash 029aff0741 MMU: Remove now-unused defines 
Now that we're using register unions where applicable, we can remove
these defines, since they're now unused.
 2021-08-31 12:18:28 -04:00
Lioncash 7a6b63b309 MMU: Don't truncate 64-bit values when calling Memcheck() 
Previously in Read_U64 and Write_U64 the value that was read or written
would be truncated to a 32-bit value before being passed off to the
memcheck handler, which can result in incorrect values being logged out.
 2021-08-31 11:39:13 -04:00
Dentomologist 1fa1e7135c DolphinQt: Make Windows tab bar scroll buttons opaque 2021-08-31 08:33:00 -07:00
Lioncash a8ebca4fc6 MMU: Invert conditionals in Memcheck() 
Lets us unindent code a little bit.
 2021-08-31 11:30:57 -04:00
Lioncash ee40b640d3 MMU: Make use of UPTE_Lo and UReg_SR in TranslatePageAddress() 
Allows us to get rid of a bit of masking in exchange for stating the
bits being accessed or written to directly.
 2021-08-31 10:52:52 -04:00
Lioncash e687569e02 Gekko: Add union for segment registers 
Will be used in the following commit.
 2021-08-31 10:45:12 -04:00
Lioncash 75840f62ff MMU: Make use of UReg_SDR1 in SDRUpdated() 
Lets us simplify SDRUpdated() a little bit.

This also fixes the layout of UReg_SDR1. Turns out this struct has been
incorrect (from a little-endian perspective) the entire time and went
unnoticed, since the union was never used.
 2021-08-31 10:20:56 -04:00
Lioncash 1c776d8c1a MMU: Move invalidation logic into the TLBEntry struct 
Puts the invalidation logic in one place and lets us tidy up
InvalidateTLBEntry a little.
 2021-08-31 10:04:44 -04:00
Lioncash 3216040bfe MMU: Remove implicit sign conversions and truncation in UpdateTLBEntry 
These are trivial to resolve.

Converting the structure member into a u32 results in no increase in
structure size, as it's making use of the three extra padding bits in
the structure.
 2021-08-31 10:00:18 -04:00
Lioncash c008b1c335 MMU: Move UPTE1/UPTE2 unions into Gekko.h 
Keeps the register definitions in one spot and lets us remove a comment
about them.
 2021-08-31 09:45:28 -04:00
Lioncash 65e131ef5f MMU: Convert PTE unions over to Common::BitField 2021-08-31 09:36:13 -04:00
Léo Lam c5becb4a7e
Merge pull request #10040 from JosJuice/simplify-mcrfs 
Interpreter: Simplify mcrfs implementation
 2021-08-31 15:31:54 +02:00
JosJuice e376a985e4 Revert "DolphinQt: Minor consistency fixes for the Settings window" 
This reverts commit 9d45bac175.
 2021-08-31 09:15:03 +02:00
Tillmann Karras 72ca41b9bf DSPInterpreter: fix off-by-one errors in cycle counting 2021-08-31 01:51:42 +01:00
Léo Lam 8ecb0447b6
Merge pull request #10025 from mbc07/gui-fixes-settings 
DolphinQt: Minor consistency fixes for the Settings window
 2021-08-31 01:43:02 +02:00
Léo Lam 48339afb98
Merge pull request #10041 from lioncash/conv 
Interpreter: Make signedness and narrowing conversions explicit
 2021-08-31 01:07:27 +02:00
Léo Lam 95fcedeef3
Merge pull request #10053 from lioncash/kdreq 
IOS/Network/KD: Minor tidy-up changes
 2021-08-31 00:45:17 +02:00
Léo Lam 1fa74ab824
Merge pull request #10058 from AdmiralCurtiss/dsp-cleanup 
DSPHLE: Minor cleanup & savestate fix for AX coefficients.
 2021-08-31 00:16:54 +02:00
Admiral H. Curtiss f592565532 DSPHLE/AX: Reload resampling coefficients on savestate load if necessary. 2021-08-30 23:36:09 +02:00
Léo Lam 271612f328
Merge pull request #10064 from lioncash/regs 
Gekko: Migrate register structs over to Common::BitField
 2021-08-30 23:19:17 +02:00
Léo Lam d7109b149b
Merge pull request #10066 from leoetlino/abort-on-panic-alert-option 
Add an option to abort when a panic alert occurs
 2021-08-30 22:43:21 +02:00