0ca4c6dbd4
Android: Add save button to cheats activity
...
By request. Matches the settings activity.
2021-09-16 18:48:40 +02:00
ffa25c4cf5
Android: Allow $ line when entering cheat code
...
Port of cda442d
2021-09-16 18:48:40 +02:00
53ae1a0725
Android: Add Gecko code downloading
2021-09-16 18:48:39 +02:00
47efd3317d
Android: Fix CheatsActivity d-pad navigation
...
Special shoutout to Android for not having RTL compatible
variants of nextFocusRight and nextFocusLeft.
Ideally we would have some way to block the user from using
the d-pad to switch between the two panes when in portrait mode,
or make the list pane act as if it's to the left of the details
pane rather than the right when the details pane is open, but I
don't know of a good way to do this. SlidingPaneLayout doesn't
really seem to have been implemented with d-pad navigation in mind.
Thankfully, landscape is the most important use case for gamepads.
2021-09-16 18:48:39 +02:00
215492152c
Android: Show warning when Enable Cheats is off
2021-09-16 18:48:39 +02:00
1470dfcf81
Android: Add the ability to delete cheats
2021-09-16 18:48:39 +02:00
404eb13e2f
Android: Add the ability to add cheats
2021-09-16 18:48:39 +02:00
6934b9a21d
Android: Add headers to cheat list
2021-09-16 18:48:38 +02:00
109aef4b81
Android: Scroll to field with error when error occurs
2021-09-16 18:48:38 +02:00
e299be1d85
Android: Add creator and notes fields for Gecko codes
2021-09-16 18:48:38 +02:00
883a9f8a99
Android: Allow viewing/editing the actual codes
2021-09-16 18:48:38 +02:00
fc6c31c3db
Android: Update cheat list when a cheat is edited
...
The way I'm implementing events using LiveData feels rather
unorthodox, but I'm not aware of anything in the Android framework
that would let me do it in a better way... One option I did
consider was wrapping the cheat lists in LiveData and observing
those, but then CheatsAdapter wouldn't know which cheat had
changed, only that there was some kind of change to the list,
necessitating the use of the not recommended notifyDataSetChanged.
2021-09-16 16:46:50 +02:00
43dcbf33ad
Android: Add edit button for cheats
2021-09-16 16:46:49 +02:00
a303b4bc98
Android: Programmatically open/close cheat details
...
Only has an effect when using a narrow screen.
2021-09-16 16:46:49 +02:00
95879c2e76
Android: Add details view for cheats
...
The details view only contains the name of the cheat for now.
2021-09-16 16:46:49 +02:00
93a1271386
Android: Add checkboxes for toggling cheats enabled
2021-09-16 16:46:49 +02:00
67a8855d9a
Android: Add "Enable Cheats" setting to GUI
2021-09-16 16:46:49 +02:00
4d609c769f
Android: Implement basic read-only cheats list
2021-09-16 16:46:48 +02:00
ee3a5a4a81
Android: Create CheatsActivity
2021-09-16 16:46:48 +02:00
bd92c29ef5
Core/CheatSearch: Avoid length underflow on new search.
2021-09-16 08:13:02 +02:00
c40e8ee3a8
Qt/CheatsManager: Show disabled AR and Gecko tabs when no game is running.
2021-09-16 08:01:40 +02:00
dd9047f7c5
Qt/GeckoCodeWidget: Disable functionality if no game id is given.
2021-09-16 08:01:40 +02:00
a4b1ea3d70
Qt/ARCodeWidget: Disable functionality if no game id is given.
2021-09-16 08:01:40 +02:00
aa2d089d1b
Qt/MenuBar: Allow opening Cheats Manager regardless of emulation state and configuration.
2021-09-16 08:01:26 +02:00
aee6e45386
Qt/CheatsManager: Let the 'Configure Dolphin' button shown in the Cheats Manager when Cheats are disabled actually open the settings.
2021-09-16 08:01:12 +02:00
4d1bd54917
Merge pull request #10095 from phire/fix-out-of-range-efb
...
BPStructs: fix out-of-range EFB copy clamping
2021-09-15 13:26:23 -04:00
57a8ee049f
Merge pull request #9886 from AdmiralCurtiss/cheat-search
...
Reimplement Cheat Search.
2021-09-15 13:25:24 -04:00
55397b6d52
DolphinQt: Rewrite cheat search GUI.
2021-09-15 19:05:49 +02:00
f3346262d2
Core/CheatSearch: Implement cheat searching functionality.
2021-09-15 19:05:48 +02:00
2b9c65967e
NetPlayClient: Change return value of OnData() to void
...
In all usage cases, the return value isn't utilized.
2021-09-15 11:31:32 -04:00
ae714b25ba
NetPlayClient: Split out OnData()
...
Over time OnData() has become a huge function-long case statement that
attempts to manage numerous packet-related behaviors, which makes it a
little difficult to reliably ensure certain handling doesn't interfere
with another case's. It's also mildly annoying to navigate due to its
size.
To make it a little easier to read and find the specific behavior, we
can break the relevant pieces of code out into their own functions.
2021-09-15 11:31:28 -04:00
94cfbfc49d
Merge pull request #10099 from AdmiralCurtiss/directoryblob-read-between-files
...
DiscIO/DirectoryBlob: Handle reads between files.
2021-09-15 14:38:37 +02:00
94e9751dfe
Merge pull request #10100 from Pokechu22/no-wglShareLists
...
GLInterface: Remove unneeded wglShareLists call
2021-09-15 14:37:19 +02:00
111c36e6cd
Merge pull request #10101 from lioncash/kb
...
SI_DeviceKeyboard: Shorten MapKeys()
2021-09-15 13:24:05 +02:00
7c909a73de
SI_DeviceKeyboard: Shorten MapKeys()
...
We can wrap this logic into a lambda to avoid copy-pasted checking of
the over 400+ lines of code.
2021-09-15 01:58:02 -04:00
eb8bfabdfd
BPStructs: make copy width/height const
2021-09-15 11:54:40 +12:00
15ec7bd546
Merge pull request #10097 from JosJuice/jitarm64-w0-clobber
...
JitArm64: Fix fresx/frsqrtex unlocking W0 too early
2021-09-14 23:51:24 +02:00
b8f4a4ae44
GLInterface: Remove unneeded wglShareLists call
...
When RenderDoc is attached, wglShareLists fails for some reason (see baldurk/renderdoc#2361 ). wglCreateContextAttribsARB has a parameter for the share context, so there's no reason to use a separate wglShareLists call.
Co-authored-by: baldurk <baldurk@baldurk.org>
2021-09-14 10:55:33 -07:00
819a0a69ff
Merge pull request #10076 from lioncash/sibf
...
SI: Migrate bitfields to Common::BitField
2021-09-14 19:10:39 +02:00
f76aaf65f6
Common/FileUtil: Strip trailing path separator in ScanDirectoryTree().
2021-09-14 17:39:38 +02:00
37b80e2170
BPStructs: fix out-of-range EFB copy clamping
...
Previous code from #7950 only clamps correctly when the efb copies
left and top coordinates are (0, 0)
Now we should handle all situations.
Spyro: A hero's tail is an example of a game that does an oversized
EFB copy with a non-zero origin.
2021-09-15 02:31:38 +12:00
06d41c53ce
DiscIO/DirectoryBlob: Handle reads between files.
2021-09-14 07:09:55 +02:00
74f2acd83b
JitArm64: Move fresx/frsqrtex RW calls earlier
...
If W0 is locked when fpr.RW is called, the indirectly called
ConvertSingleToDoubleLower may need to emit a push+pop, so it's
better for fresx/frsqrtex to call RW before locking W0 than after.
2021-09-13 19:27:16 +02:00
1c4155f800
JitArm64: Fix fresx/frsqrtex unlocking W0 too early
...
fpr.RW may clobber GPRs that are not locked.
Fixes https://bugs.dolphin-emu.org/issues/12656 .
2021-09-13 19:03:43 +02:00
d00e7d5a75
SI: Collapse interrupt generation check in UpdateInterrupts()
...
We can simplify this by storing the result of the test into a variable
instead.
2021-09-13 11:25:03 -04:00
ca24c32cbf
SI: Eliminate trivial sign conversion cases in RegisterMMIO()
...
Previously differently signed types were being used to create addresses
and bit offsets.
2021-09-13 11:24:59 -04:00
ee863e6722
Merge pull request #10014 from OatmealDome/wiimote-disconnect-crash
...
WiimoteReal: Fix Wiimote disconnection causing Dolphin to crash on macOS
2021-09-13 15:26:02 +02:00
5f2a8d98fb
Merge pull request #10093 from JosJuice/revert-revert-10025
...
Revert "Revert "DolphinQt: Minor consistency fixes for the Settings window""
2021-09-13 14:54:01 +02:00
1b32a61d6a
Merge pull request #10094 from AdmiralCurtiss/namco-museum-branch-following
...
GameINI: Disable JIT branch following for Namco Museum.
2021-09-10 23:42:04 -04:00
788177a001
GameINI: Disable JIT branch following for Namco Museum to avoid major stuttering in Galaga Arrangement and Dig Dug Arrangement.
2021-09-11 05:27:07 +02:00
JosJuice