ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
43,382 Commits 10 Branches 16 Tags 1.6 GiB
Commit Graph

36880 Commits

Author SHA1 Message Date
cristian64 6d8ba94e4c DolphinQt: Extract creator name from code name in Gecko codes. 
Gecko codes in Dolphin feature a dedicated field for the creator of the
cheat code. When saved into the INI file, the code name and the creator
name are concatenated, and then inserted in the `[Gecko]` section:

```ini
[Gecko]
$<cheat code name> [<creator>]
<code line 1>
<code line 2>
<code line 3>
<...>
$<other cheat code name> [<creator>]
<code line 1>
<code line 2>
<code line 3>
<...>
```

On the other hand, enabled codes are listed under the `[Gecko_Enabled]`
section, but in this case the creator name is omitted from the line:

```ini
[Gecko_Enabled]
$<cheat code name>
$<other cheat code name>
```

Having the creator name in the `[Gecko]` section but not in the
`[Gecko_Enabled]` section is arguably not ideal, but this is legacy
behavior in Dolphin.

The **Cheat Code Editor** dialog is not acknowledging this subtle
behavior in Dolphin: the cheat code name and the creator name *can* be
both inserted in the name field. This issue manifests as an inconsistent
state where a Gecko code that *appears* to be enabled has no effect when
the game is launched.

As part of this fix, the creator name (if present) is now moved into the
dedicated creator field before the code is stored internally.

Test plan:

- Right-click on any game and open the **Properties** dialog.
- Switch to the **Gecko Codes** tab.
- Press the **Add New Code...** button.
- In the **Cheat Code Editor** dialog:
  - Enter `This is a test [Jane Doe]` in the **Name:** field.
  - Enter `01234567 00000000` in the **Code:** field.
  - Press **Save**.
- Observe that the newly added code is now in the list, and *appears* to
  be enabled.
- Close the **Properties** dialog.
- Right-click on the same game and open the **Properties** dialog again.

**Without** the fix, the newly added code, while still on the list, has
been inadvertently disabled (it was never really enabled!).

**With** the fix, the newly added code is the list and remains enabled.

This fixes https://bugs.dolphin-emu.org/issues/13695.
 2025-03-23 21:37:23 +00:00
JosJuice 9e9faf3be1 Android: Show message when trying to map disconnected device 
Having the MotionAlertDialog immediately close is confusing for users.
Let's show a message to tell them what went wrong.
 2025-03-23 21:39:08 +01:00
JosJuice 516c1314d2 Android: Don't use separate thread for MotionAlertDialog 
This is an Android continuation of bc95c00. We now call
InputDetector::Update immediately after receiving an input event from
Android instead of periodically calling it in a sleep loop. This
improves detection of very short inputs, which are especially likely to
occur for volume buttons on phones (or at least on my phone) if you
don't intentionally keep them held down.
 2025-03-23 21:39:04 +01:00
JMC47 ad3650abfc
Merge pull request #13093 from mitaclaw/ranges-modernization-4-projection 
Ranges Algorithms Modernization - Projection
 2025-03-23 15:56:13 -04:00
JMC47 1515cf6ccd
Merge pull request #13447 from JosJuice/bba-panic-tr 
EXI: Make HLE BBA panic alerts translatable
 2025-03-23 15:22:11 -04:00
JMC47 cef4d8fb76
Merge pull request #13432 from iwubcode/custom_pixel_fragment 
VideoCommon: move to a 'process_fragment()' function to simplify custom shaders
 2025-03-23 15:21:48 -04:00
JMC47 f50d2ee86c
Merge pull request #13425 from jordan-woyak/after-present-cleanup 
Fix performance statistics when Skip Duplicate Frames is turned off.
 2025-03-23 15:21:31 -04:00
JMC47 28f1beeca8
Merge pull request #13398 from jordan-woyak/perf-tracker 
PerformanceTracker: Eliminate mutex. General cleanups.
 2025-03-23 15:21:11 -04:00
JMC47 178462e10f
Merge pull request #13385 from Tilka/sp2_ad16 
Fix AD16 and make SP2 configurable
 2025-03-23 15:20:45 -04:00
JMC47 9b0471532c
Merge pull request #13368 from jordan-woyak/anisotropic-filtering 
Use Game Requested Anisotropic Filtering
 2025-03-23 15:17:24 -04:00
JMC47 2da255d8cd
Merge pull request #13311 from iwubcode/dynamic_input_textures_reduce_image_writes 
Core / DolphinQt / InputCommon: reduce the number disk writes when using DynamicInputTextures
 2025-03-23 15:12:28 -04:00
JMC47 e93f0de8a4
Merge pull request #13295 from jordan-woyak/controller-emu-cleanup 
InputCommon/ControllerEmu: Break out functionality of EmulatedController to eliminate redundant members.
 2025-03-23 15:12:06 -04:00
JosJuice c1990bc687 EXI: Make HLE BBA panic alerts translatable 
Also rewording the messages to make them clearer and fix typos.
 2025-03-23 15:43:16 +01:00
iwubcode 8e253518e6 VideoCommon: move to a 'process_fragment()' function to simplify custom shaders and provide a direct override of the tev stage logic 2025-03-22 15:22:00 -05:00
iwubcode e18d98d4fc Core: properly distinguish between ES title switches (Wii titles) and normal loading (GC, also called for Wii..); update config for ES title change, generate textures for both situations 2025-03-22 14:55:20 -05:00
iwubcode d03f9032c1 Core / DolphinQt / InputCommon: reduce the number disk writes when using DynamicInputTextures 2025-03-22 14:53:02 -05:00
TryTwo b0867c1602 CodeWidget: Layout tweak. Give left-side widgets more vertical space by moving the address bar out of the way. Align things better. 2025-03-21 09:55:52 -07:00
Jordan Woyak 3bf2de369a WiimoteEmu: Eliminate dynamic memory allocation in speaker data decoding. 2025-03-18 03:12:50 -05:00
Jordan Woyak 561aee7707 Config: Expose Default and 1x Anisotropic Filtering setting. 2025-03-17 20:46:24 -05:00
Jordan Woyak 4b711e1e0a DolphinQt: Allow ConfigComplexChoice to handle DefaultState values. 2025-03-17 20:46:24 -05:00
Jordan Woyak ba1bf6959e Config: Allow passing a DefaultState object to Set functions to delete keys. 2025-03-17 20:46:24 -05:00
Jordan Woyak 137d1375d4 Enable game-requested anisotropic filtering in Metal backend. 2025-03-17 20:46:24 -05:00
Pokechu22 79a1e480ca Enable anisotropic filtering when the game requests it 2025-03-17 20:46:19 -05:00
Jordan Woyak a7d1cac8ad Core: Call PerformanceMetrics::CountFrame regardless of PresentReason. 2025-03-17 17:24:08 -05:00
JosJuice 0299540209
Merge pull request #13397 from jordan-woyak/perf-metrics 
PerformanceMetrics: Eliminated a mutex. Code cleanups.
 2025-03-17 23:20:41 +01:00
Tillmann Karras 6a90affa38 Fix -Wunused-lambda-capture warning 2025-03-17 20:08:19 +00:00
OatmealDome 0afbeae70c
Merge pull request #13430 from jordan-woyak/tatacon-desired-state 
WiimoteEmu: Make TaTaCon DesiredState use only one byte of space.
 2025-03-16 15:04:21 -04:00
OatmealDome 49bee36e6a
Merge pull request #13435 from iwubcode/uninitialized_directx 
VideoCommon: initialize uninitialized state value in pixel ubershader
 2025-03-16 14:56:44 -04:00
OatmealDome 9720b1f5f5
Merge pull request #13411 from jordan-woyak/gui-vconfig 
DolphinQt/GeneralWidget: Eliminate unnecessary g_Config usage.
 2025-03-16 14:54:24 -04:00
OatmealDome 9e513d93e1
Merge pull request #13414 from jordan-woyak/vconfig-framedump 
VideoConfig: Eliminate frame dumping members.
 2025-03-16 14:53:47 -04:00
OatmealDome 07cec796f4
Merge pull request #13417 from luzpaz/typo-source-core-common 
Core/Common: Fix typos
 2025-03-16 14:53:02 -04:00
iwubcode c5f89f2de9 VideoCommon: initialize uninitialized state value in pixel ubershader to prevent error on directx in some games 2025-03-16 11:35:56 -05:00
Jordan Woyak 48b2f7d200 VideoConfig: Eliminate frame dumping members. 2025-03-16 04:30:06 -05:00
iwubcode c1dea828ab Common: use std::chrono for GetLocalTimeSinceJan1970 on Windows 
Co-authored-by: Shawn Hoffman <godisgovernment@gmail.com>
 2025-03-16 00:59:45 -05:00
iwubcode 452cd1c261 Core: use more recent api in ComputeDefaultCountryCode on Windows 
Co-authored-by: Shawn Hoffman <godisgovernment@gmail.com>
 2025-03-16 00:59:45 -05:00
iwubcode 373a1a5dc0 Update min win10 version from 1703/15063 to 1903/18362 
Co-authored-by: Shawn Hoffman <godisgovernment@gmail.com>
 2025-03-16 00:59:45 -05:00
JMC47 f4c37aeb14
Merge pull request #13423 from jordan-woyak/async-request-cleanup-1 
AsyncRequests Cleanups.
 2025-03-15 18:17:29 -04:00
Tillmann Karras 90b6f0d16d Config: make SP2 configurable 2025-03-15 22:03:17 +00:00
Tillmann Karras 951a84833a EXI: fix AD16 
The GameCube IPL is now able to detect this device. However, this
triggers some memory clearing code that trips up Dolphin's I$.
 2025-03-15 22:03:16 +00:00
Jordan Woyak 6aff82eda3 WiimoteEmu: Make TaTaCon DesiredState use only one byte of space. 2025-03-15 16:48:05 -05:00
JMC47 99cde4e269
Merge pull request #13395 from jordan-woyak/vi-HORIZONTAL_BEAM_POSITION-ticks 
VideoInterface: Update m_ticks_last_line_start from the event's ticks value.
 2025-03-15 17:27:07 -04:00
JMC47 1bd3e79fda
Merge pull request #13378 from jordan-woyak/desired-ext-state 
WiimoteEmu: Clean up variant handling in DesiredExtensionState.
 2025-03-15 17:26:49 -04:00
JMC47 e3deb14156
Merge pull request #13347 from iwubcode/custom_shader_overhaul_lighting 
VideoCommon: move lighting shader logic to callable functions
 2025-03-15 17:26:32 -04:00
Jordan Woyak 46e0952e97 PerformanceTracker: Use SPSCQueue and atomic to eliminate need for a mutex. Clean up some math. 2025-03-15 14:40:00 -05:00
Jordan Woyak c763961112 PerformanceTracker: Use std::deque instead of hand-rolled circular 
queue.
 2025-03-15 14:40:00 -05:00
Jordan Woyak b2ce3fbefc PerformanceTracker: Pass chrono values instead of us s64. 2025-03-15 14:40:00 -05:00
Jordan Woyak ddb82a5e8c InputCommon/ControllerEmu: Break out functionality of EmulatedController 
to eliminate redundant unused members in Wii Remote extension objects.
 2025-03-15 14:30:43 -05:00
JMC47 225039f742
Merge pull request #13427 from LillyJadeKatrin/retroachievements-code-approval-fix 
Fixed Multi Config Code Approvals
 2025-03-15 13:57:48 -04:00
JosJuice f2d1918714 Fix broken merge of PR #13181 
This undoes one of the changes of PR #13181. I'm guessing the relevant
code changed between when the PR was last pushed to and when it was
merged.
 2025-03-15 17:23:39 +01:00
JosJuice e637a05707
Merge pull request #12866 from JosJuice/android-log-types-sorting 
Android: Replace log type names map with array
 2025-03-15 16:01:33 +01:00
JosJuice 1f087473aa
Merge pull request #12809 from JosJuice/jitarm64-cmp-sp 
JitArm64: Replace a comparison to SP
 2025-03-15 16:00:15 +01:00
JosJuice b2f8dac739
Merge pull request #13271 from dreamsyntax/gradle-wrapper 
Android: Upgrade AGP & Gradle
 2025-03-15 15:59:21 +01:00
JosJuice 541344ef9b
Merge pull request #13240 from thalesmg/20241225-m-known-bt-addresses-config-only 
feat(linux): allow configuring real wiimotes with known bluetooth addresses
 2025-03-15 15:34:49 +01:00
JosJuice 8c7ab286f5
Merge pull request #13181 from tygyh/Replace-'reinterpret_cast' 
Replace 'reinterpret_cast' with 'static_cast'
 2025-03-15 15:31:38 +01:00
JosJuice 3fb4084e25
Merge pull request #13345 from Tilka/unswap_depth 
Fix depth texture being incorrectly affected by swap table
 2025-03-15 14:30:19 +01:00
JosJuice fd2c6918fa
Merge pull request #13388 from jordan-woyak/vsync-not-recommended 
DolphinQt: Don't recommend v-sync for optimal frame pacing in tool-tip.
 2025-03-15 14:24:29 +01:00
LillyJadeKatrin 0615ade725 Fixed Multi Config Code Approvals 
Refactors the AR/Gecko/Patch code approval process to verify from every possible game ini, not just the base game ID. This fixes codes on specific revisions or codes general to any region.
 2025-03-15 07:57:16 -04:00
Jordan Woyak 2690a62949 Core: Remove unused GetActualEmulationSpeed function and related variables/functions. 2025-03-14 03:10:13 -05:00
Jordan Woyak e1745f682f PerformanceMetrics: Eliminated a mutex. Code cleanups. 2025-03-14 03:10:13 -05:00
Sam Belliveau f09ba10daa AudioCommon: Added Granular Synthesis 2025-03-14 01:22:35 -05:00
Jordan Woyak 6c158ed590 VideoCommon: Create AsyncRequests directly in MMU code to eliminate EFB-related functions in VideoBackendBase. 2025-03-14 01:14:51 -05:00
Jordan Woyak 63b848ca93 VideoCommon: Eliminate EFBAccessType enum. Eliminate union and switch statement handler in AsyncRequests. 2025-03-14 00:59:41 -05:00
iwubcode 15372dc835 VideoCommon: move lighting shader logic to callable functions 2025-03-13 23:56:04 -05:00
JMC47 ca9b34a6d1
Merge pull request #13394 from jordan-woyak/odd-even-pacing 
VideoInterface: Adjust even-field to match odd-field pacing when PSB values differ.
 2025-03-13 21:56:36 -04:00
JMC47 0e2785a562
Merge pull request #13387 from jordan-woyak/frame-pacing 
CoreTiming: Improve frame pacing
 2025-03-13 14:23:18 -04:00
Jordan Woyak 5b36c13bfb VideoCommon: Rename Renderer to EFBInterface. 2025-03-12 21:09:16 -05:00
Luz Paz 1b47dbf519 Core/Common: Fix typos 
Found via `codespell -q 3 -S "./Externals,./Data/Sys/wiitdb-??.txt,*.po,*.pot" -L andf,asnd,bootup,brocken,bufferin,clen,collet,datas,delt,diety,extint,fpr,inout,inport,interm,nd,nin,ontop,pixelx,re-use,re-used,sav,stateman,strat,transer,wil`
 2025-03-11 19:48:45 -04:00
JMC47 de997d616f
Merge pull request #13416 from jordan-woyak/unused-viewport-correction 
VertexShaderManager: Eliminate unnecessary m_viewport_correction member.
 2025-03-11 19:00:55 -04:00
JMC47 b7bd0a0836
Merge pull request #13413 from jordan-woyak/vconfig-progressive 
VideoConfig: Eliminate bForceProgressive.
 2025-03-11 18:59:28 -04:00
JMC47 67c8d5640f
Merge pull request #13412 from jordan-woyak/netplay-vconfig 
VideoConfig: Eliminate NetPlay related members.
 2025-03-11 18:59:02 -04:00
JMC47 1698daef66
Merge pull request #13410 from jordan-woyak/movie-vconfig 
Movie: Eliminate MovieManager::SetGraphicsConfig.
 2025-03-11 18:58:45 -04:00
Jordan Woyak c191ed5321 VertexShaderManager: Eliminate unnecessary m_viewport_correction member. 2025-03-11 03:55:57 -05:00
Jordan Woyak 5b88c0b90e DolphinQt/GeneralWidget: Eliminate unnecessary g_Config usage. 2025-03-10 20:19:45 -05:00
Jordan Woyak de01a790e1 VideoConfig: Eliminate bForceProgressive. 2025-03-10 19:02:43 -05:00
Jordan Woyak 7f3d8a1ad4 VideoConfig: Eliminate NetPlay related members. 2025-03-10 18:53:44 -05:00
Jordan Woyak 44423a3656 Movie: Eliminate MovieManager::SetGraphicsConfig. 2025-03-10 18:16:49 -05:00
Jordan Woyak 7222188cde Core/VideoCommon: Push presentation time calculated from CPU thread to GPU thread. 2025-03-10 16:40:46 -05:00
Jordan Woyak c4bd98c626 VideoInterface: Throttle before VBlank statistics counting. 2025-03-10 16:40:46 -05:00
Jordan Woyak 9ac9813492 SystemTimers: Throttle prior to performance marker. 2025-03-10 16:40:46 -05:00
Jordan Woyak aa624d8ba8 BTEmu: Throttle prior to wii remote input update. 2025-03-10 16:40:46 -05:00
Jordan Woyak 9675c90890 VideoInterface: Throttle prior to SI poll. 2025-03-10 16:40:46 -05:00
Jordan Woyak 81e842e2aa CoreTiming: Don't Throttle in event queue processing. 2025-03-10 16:39:13 -05:00
Jordan Woyak fe2d247acb VideoCommon: Don't merge EFBPoke AsyncRequests. 2025-03-10 16:37:24 -05:00
mitaclaw 433c6ce0f2 GCC: Remedy NRVO Fails 
Using the `-Wnrvo` flag introduced by GCC 14, I identified a few places where NRVO was clearly intended, but is fumbled.
 2025-03-10 12:38:03 -07:00
JMC47 5ed8b7bc9d
Merge pull request #13403 from jordan-woyak/backend_info 
VideoCommon: Move backend_info out of VideoConfig struct.
 2025-03-10 15:06:19 -04:00
JMC47 d45e6c6729
Merge pull request #13401 from jordan-woyak/exit-gpu-loop 
Core/VideoBackendBase: Call ExitGpuLoop from Core to eliminate Video_ExitLoop.
 2025-03-10 15:05:30 -04:00
JMC47 203454a97a
Merge pull request #13396 from jordan-woyak/vi-odd-even 
VideoInterface: Cleanup and minor fix in Update.
 2025-03-10 15:05:12 -04:00
JMC47 ff4486ee23
Merge pull request #13340 from Dentomologist/state_show_decompressing_osd_longer 
State: Show "Decompressing State..." OnScreenDisplay message for longer
 2025-03-10 15:04:50 -04:00
JMC47 189d09011b
Merge pull request #13363 from JoshuaVandaele/nowarnings 
Fix multiple minor warnings
 2025-03-10 15:04:14 -04:00
JMC47 3f73a39dbd
Merge pull request #13286 from JoshuaVandaele/xcb 
Enforce XCB within code
 2025-03-10 15:03:54 -04:00
JMC47 9f43f59c9b
Merge pull request #13276 from JoshuaVandaele/sfml-3.0.0 
Migrate to SFML 3.0.0
 2025-03-10 15:03:36 -04:00
mitaclaw e4efe011d7 Modernize `std::max_element` with ranges and projections 2025-03-09 13:26:39 -07:00
mitaclaw 258ec4f9cd Modernize `std::lower_bound`/`upper_bound` with ranges and projections 2025-03-09 13:26:38 -07:00
mitaclaw c9f589faa5 Modernize `std::stable_sort` with ranges and projections 2025-03-09 13:26:38 -07:00
mitaclaw 8b9f92a0af Modernize `std::sort` with ranges and projections 
In PPCTables.cpp, the code is currently unused so I was unable to test it.

In CustomPipeline.cpp, a pointer to member function cannot be used due to 16.4.5.2.1 of the C++ Standard regarding "addressable functions". https://eel.is/c++draft/namespace.std#6

In Fs.cpp and DirectoryBlob.cpp, these examples used projections in a previous iteration of this commit, but no longer do. Still, they remain in this commit because the PR they would actually belong to is already merged.
 2025-03-09 13:26:38 -07:00
mitaclaw 9f972db4b8 Modernize `std::none_of` with ranges and projections 2025-03-09 13:26:37 -07:00
mitaclaw 00e147c722 Simplify `std::count_if` with `std::ranges::count` and projections 2025-03-09 13:26:37 -07:00
mitaclaw 62b2b939b5 Simplify `std::find_if` with `std::ranges::find` and projections 
In LabelMap.cpp, the code is currently unused so I was unable to test it.

In WiiUtils.cpp, the magic value `1u` was replaced by the constant value `DiscIO::PARTITION_UPDATE`.
 2025-03-09 13:26:35 -07:00
mitaclaw 1e5e9219cd Common: Create Range Projections For `std::pair` 2025-03-09 13:19:41 -07:00
JosJuice 87496205aa
Merge pull request #13404 from luzpaz/typo-source-core-windupdater 
Core/WinUpdater: fix typo
 2025-03-09 12:03:56 +01:00