140daf5960
Merge pull request #9268 from leoetlino/devicememcard-minor-cleanup
...
EXI_DeviceMemoryCard: Medium cleanup
2020-11-25 10:07:44 +01:00
12a215c232
Merge pull request #9277 from JosJuice/gles-vertex-uber
...
Fix vertex ubershader GLES compile errors
2020-11-25 10:04:45 +01:00
4a21be5d77
Merge pull request #9278 from lioncash/latent
...
Core: Convert missed log calls over to fmt
2020-11-25 09:58:40 +01:00
bf0fe0281a
Fix bounding box incorrectly disabled on OpenGL ES 3.1, 3.2
2020-11-24 21:22:39 +01:00
ee06963644
Merge pull request #9279 from JosJuice/rb3-midi-passthrough
...
Add Rock Band 3 MIDI PRO Adapter to known Wii peripherals
2020-11-24 10:35:08 -05:00
d01f85cfd8
Add Rock Band 3 MIDI PRO Adapter to known Wii peripherals
...
Based on info from https://forums.dolphin-emu.org/Thread-emulate-midi-pro-adapter
2020-11-24 14:25:19 +01:00
eedfe2abf1
Core: Convert missed log calls over to fmt
2020-11-23 12:20:02 -05:00
6cd718163f
Core: Convert logging over to fmt pt.4
...
Continues the migration of logging in the Core library. This part
finishes up the remaining log calls within the IOS code.
2020-11-23 11:53:21 -05:00
28c696fa74
Fix vertex ubershader GLES compile errors
...
Regression from 51724c1
2020-11-23 11:42:41 +01:00
17b11cf4a4
Merge pull request #9095 from JosJuice/android-reset-setting
...
Android: Long press a setting to reset it
2020-11-23 02:50:40 +01:00
b555f0fb93
Merge pull request #9265 from lioncash/core-log3
...
Core: Convert logging over to fmt pt.3
2020-11-23 02:46:58 +01:00
b53127a1fa
Merge pull request #9274 from JosJuice/av-register-all
...
FrameDump: Re-add call to av_register_all
2020-11-22 12:45:59 +01:00
79f50cd4fd
IP/Top: Fix fallback IP address
2020-11-22 15:34:27 +04:00
5d9eb8f6ce
Merge pull request #9271 from leoetlino/warnings
...
Fix several warnings and only enable extra warnings for our own code
2020-11-22 02:04:53 +01:00
118d056410
FrameDump: Re-add call to av_register_all
...
This was removed in 4902146329
2020-11-22 00:11:23 +01:00
d3537e68d1
Merge pull request #9273 from leoetlino/msvc-preprocessor-fix
...
CMake: Pass various /Zc flags to MSVC for consistency with Base.props
2020-11-21 09:03:25 -05:00
f53a7a2b66
CMake: Pass various /Zc flags to MSVC for consistency with Base.props
...
969ea6e4f5
2020-11-21 14:43:26 +01:00
cbbf044064
Core: Convert logging over to fmt pt.3
...
Continues the migration over to fmt up to IOS' ES module.
2020-11-21 05:56:37 -05:00
41b79a66c7
Merge pull request #9270 from leoetlino/dtm-gameid-null
...
Core/Movie: Fix a likely out-of-bounds read for PanicAlertT
2020-11-21 01:53:15 -05:00
608dd6a37b
Merge pull request #9122 from Pokechu22/pr-4601-test
...
Fix Super Mario Sunshine debug cubes (originally PR #4601 by stenzek)
2020-11-21 02:55:50 +01:00
9efc81ae98
Fix variable shadowing warnings
2020-11-21 02:08:09 +01:00
7840f61524
Silence "missing switch cases" warnings
2020-11-21 02:08:09 +01:00
6ab1ab1f12
Fix -Wmaybe-uninitialized warnings
2020-11-21 02:08:09 +01:00
82f1e6204d
Fix -Wsign-compare warnings
2020-11-21 02:08:09 +01:00
4b7f784d1b
Disable -Wstringop-truncation warnings
...
Disable -Wstringop-truncation warnings as they result in many false
positives.
In most (all?) cases where std::strncpy is used, we want to fill the
entire buffer or match emulated code that also ignores the null
terminator, so the warnings are not useful.
Given that Dolphin itself mostly uses std::string, they do not
really help catch any bugs.
2020-11-21 02:08:08 +01:00
83b9feff90
Core/Movie: Fix a likely out-of-bounds read for PanicAlertT
...
gameID isn't null terminated since it is just an std::array<char, 6>
and .data() returns a char* so {fmt} would go way beyond the bounds of
the array when it attempts to determine the length of the string.
The fix is to pass a std::string_view to {fmt}. This commit adds
a GetGameID() function that can also be used to simplify
string comparisons.
2020-11-21 01:30:02 +01:00
ade9f92a63
Enable extra warnings in Source CMakeLists, not in root CMakeLists
...
Having extra warnings enabled for everything including external
libraries produces an overwhelming amount of warnings in code that
isn't even part of our codebase.
Move the various warning flags to Source/CMakeLists.txt to get rid
of those useless warnings.
Note that the Source CMakeLists.txt is already where the MSVC warnings
are defined, so this commit improves consistency as well.
2020-11-21 00:59:17 +01:00
d6ce8eef36
Software: Use same logic for colors as hardware backends
2020-11-20 15:54:06 -08:00
51724c1ccd
LightingShaderGen: Always calculate lighting for both color channels
...
Cel-damage depends on lighting being calculated for the first channel
even though there is no color in the vertex format (defaults to the
material color). If lighting for the channel is not enabled, the vertex
will use the default color as before.
The default value of the color is determined by the number of elements in
the vertex format. This fixes the grey cubes in Super Mario Sunshine.
If the color channel count is zero, we set the color to black before the
end of the vertex shader. It's possible that this would be undefined
behavior on hardware if a vertex color index that was greater than the
channel count was used within TEV.
2020-11-20 15:54:04 -08:00
fa73b1a23f
Merge pull request #9269 from JosJuice/fmt-positional-checks
...
Common: Assert that translatable strings use positional arguments
2020-11-21 00:29:43 +01:00
115dedec63
Android: Fix default values for GC/Wii controller 1
2020-11-20 22:17:00 +01:00
0dcb6794d3
Android: Remove "Reset Paths to Default Settings"
...
There is now a more general way of resetting settings,
so we don't need this.
2020-11-20 22:17:00 +01:00
064cde9774
Android: Long press a setting to reset it
...
This is particularly important for game INIs, where a setting being
unset is not the same as it being set to the default value.
2020-11-20 22:17:00 +01:00
33f15f22e2
Merge pull request #9266 from JosJuice/android-startup-illegalstate
...
Android: Fix IllegalStateException on startup
2020-11-20 22:13:30 +01:00
e4ceed2bed
Common: Assert that translatable strings use positional arguments
...
Like PR 9260, but for a different requirement (see PR 9253).
2020-11-20 20:24:30 +01:00
e63b00e562
Fix translatable strings which contain non-positional arguments
2020-11-20 20:24:30 +01:00
f82145d9dd
EXI_DeviceMemoryCard: Use std::array
2020-11-20 19:41:23 +01:00
f81062f561
EXI_DeviceMemoryCard: Use enum class for Command
2020-11-20 19:38:07 +01:00
b2f00be637
EXI_DeviceMemoryCard: Fix member variable names
2020-11-20 19:37:39 +01:00
1f15119f80
EXI_DeviceMemoryCard: Use override rather than virtual
2020-11-20 19:36:34 +01:00
279197b278
EXI_DeviceMemoryCard: Use more efficient overload of find_last_of
2020-11-20 19:36:34 +01:00
4ad88ce2e4
EXI_DeviceMemoryCard: Clean up casts and implicit conversions
2020-11-20 19:36:33 +01:00
e144d20dd6
EXI_DeviceMemoryCard: Remove unused include
2020-11-20 18:51:16 +01:00
2631243379
EXI_DeviceMemoryCard: Rename variables to follow our naming conventions
2020-11-20 18:51:16 +01:00
730f9cb7bd
Android: Fix IllegalStateException on startup
...
See https://github.com/dolphin-emu/dolphin/pull/9095#pullrequestreview-535576465
2020-11-20 18:33:00 +01:00
17da28ff07
Merge pull request #9267 from leoetlino/fix-lambda-captures
...
Core: Fix invalid lambda captures
2020-11-20 18:32:47 +01:00
542c49bab0
Core: Fix invalid lambda captures
...
PR #9260 made the MsgAlert macros use lambdas so that local
constexpr variables can be added while keeping the ability to
return a boolean from the macros.
Unfortunately, C++17 forbids referring to structured bindings in lambda
captures. This is fixed in P1091R3 but we cannot rely on C++20 yet...
2020-11-20 18:27:56 +01:00
f45a4a5916
Merge pull request #9263 from lioncash/core-log2
...
Core: Convert logging over to fmt pt.2
2020-11-20 16:36:47 +01:00
7f5cecf7ef
Merge pull request #9264 from leoetlino/fix-fmt-log
...
DSP: Fix one DEBUG_LOG call
2020-11-20 10:21:48 -05:00
88cc1b7c8a
DSP: Fix one DEBUG_LOG call
2020-11-20 16:21:05 +01:00
Léo Lam