184fe932ed
AchievementManager: std::move leaderboard info in FetchBoardInfo()
...
Avoids churning some allocations.
2024-02-01 23:03:24 -05:00
76c381e6f7
AchievementManager: Ensure update callback is always valid
...
This way we don't need to do any validity checking aside from the
initial setting of the callback. Also cuts down on line noise.
2024-02-01 23:03:23 -05:00
2b83cc739a
AchievementManager: Convert .compare() into equality operators
...
These perform a default comparison, which is the same as using the
equality operators.
2024-02-01 23:03:23 -05:00
394418b415
AchievementManager: Remove unnecessary .get()
...
Same behavior, less code.
2024-02-01 23:03:23 -05:00
161efff6c9
AchievementManager: Remove long qualifier
...
We can remove the long qualifying on some ResponseType instances to
lessen the amount of reading.
2024-02-01 23:03:23 -05:00
7096f99f79
CustomPipeline: Mark arrays as constexpr
...
Ensures that these go into the ro section.
2024-02-01 23:02:45 -05:00
59211589b9
CustomPipeline: Make use of emplace_back() in GlobalConflicts()
...
We can use the string_view arguments to directly construct strings
inside of the global_result vector.
2024-02-01 23:02:45 -05:00
353ceedb50
CustomPipeline: Resolve unused variable warning
...
We can just use holds_alternative here instead.
2024-02-01 23:02:45 -05:00
085c4d154e
CheatSearch: Remove redundant lambdas
...
Core::RunAsCPUThread is obsoleted by CPUThreadGuard reference already passed into the function. The nonsense lambda in CheatSearchWidget is from changes in fdb7328c73
2024-02-01 19:54:47 -08:00
d96d2cd68c
Translation resources sync with Transifex
2024-02-01 21:47:52 +01:00
24704fc279
Merge pull request #12554 from AdmiralCurtiss/boot-nandtitle-fix
...
Core: Fix booting titles from NAND.
2024-02-01 20:33:21 +01:00
951be30891
Core: Fix booting titles from NAND.
2024-02-01 19:50:20 +01:00
3a9860eb6e
Merge pull request #12514 from SuperSamus/hidapi-submodule
...
Externals/hidapi: Convert to submodule
2024-02-01 19:49:48 +01:00
438f5c3412
Merge pull request #12548 from AdmiralCurtiss/dead-automatic-start
...
Core/ConfigManager: Remove dead bAutomaticStart flag.
2024-01-31 17:42:24 -05:00
14121c5504
Core/ConfigManager: Remove dead bAutomaticStart flag.
2024-01-31 22:53:43 +01:00
da6b5dd38a
Merge pull request #12546 from lioncash/event
...
VideoCommon/Statistics: Remove global system accessor from s_after_frame_event
2024-01-31 21:16:21 +01:00
18abf7c768
Merge pull request #12544 from lioncash/getmod
...
GraphicsModGroup: Allow heterogenous lookup for GetMod()
2024-01-31 20:17:26 +01:00
202c10d757
Merge pull request #12547 from lioncash/movie
...
Core/Movie: Remove lingering global system instance accessors
2024-01-31 20:12:07 +01:00
2509164ce4
Merge pull request #12545 from lioncash/hash
...
VideoCommon: Collapse hash specialization namespaces
2024-01-31 20:04:15 +01:00
5ade2e39ef
Core/Movie: Remove lingering global system instance accessors
...
The movie manager is already passed in a reference to the relevant
system, so we can use that instead.
2024-01-31 13:30:24 -05:00
16d8b6e6b3
Common/HookableEvent: std::move callback instance in Register()
...
Potentially avoids reallocations if the capture buffer of the callback
is quite large.
2024-01-31 13:16:50 -05:00
cac66317aa
VideoCommon/Statistics: Remove global system accessor from s_after_frame_event
...
Instead, we make the event take a reference to the system and then pass
it in when the event is triggered.
This does introduce two other accessors, but these are much easier to
refactor out over time, and without modification to the existing event
interface.
2024-01-31 13:12:09 -05:00
0dfefacdf4
VertexLoaderBase: Collapse std namespace for hash and mark noexcept
...
Makes the hash specialization a little less noisy. Also we mark it
noexcept, since hashes shouldn't be throwing exceptions (and this can be
optimized on).
2024-01-31 12:43:00 -05:00
8e4b2565cd
TextureConfig: Collapse std namespace for hash
...
Lets us collapse the namespacing and make the specialization a little
less noisy.
2024-01-31 12:41:33 -05:00
b63dcd504d
RenderState: Collapse std namespace for hash
...
We can specify the namespace on the hash to make the specialization a
little less noisy.
2024-01-31 12:40:10 -05:00
5bfaa3a966
NativeVertexFormat: Collapse std namespace and mark hash noexcept
...
We can just tag the std:: onto the end of the specialization to make it
less noisy.
Also mark it as noexcept, since hashes shouldn't throw exceptions.
2024-01-31 12:37:44 -05:00
40b050fe37
GraphicsModGroup: std::move graphics_mod in Load()
...
The config object is quite heavyweight, so we should move this instead
of copying.
2024-01-31 12:27:43 -05:00
ccacda5e2c
GraphicsModGroup: Simplify try_add_mod()
...
We can use contains() here, and also move the mod config if it's valid
instead of copying it, since it contains quite a bit of allocated data.
2024-01-31 12:23:21 -05:00
81aca79145
GraphicsModListWidget: Pass optional by const reference
...
All we do is read from it, so we don't need to copy the string if we
happen to have one.
2024-01-31 12:09:35 -05:00
a1879ea099
GraphicsModGroup: Allow heterogenous lookup for GetMod()
...
Allows using keys that aren't directly std::string as the key. This lets
us use std::string_view for the incoming path name, making it more
flexible with other string types.
2024-01-31 12:05:17 -05:00
30fdf25f8f
Merge pull request #12542 from AdmiralCurtiss/system-sconfig
...
Migrate m_is_mios and bWii from SConfig to System.
2024-01-31 09:57:17 -05:00
9a3e770c23
Migrate SConfig::bWii to System.
2024-01-31 12:54:07 +01:00
e0828815e7
Merge pull request #12540 from mitaclaw/encode-reg-to-64
...
Add Missing EncodeRegTo64 in JitArm64::dcbx
2024-01-30 13:08:03 -05:00
45481620b8
Add Missing EncodeRegTo64 in JitArm64::dcbx
...
ARM64FloatEmitter::ABI_PushRegisters expects an XReg temporary, not a WReg.
2024-01-30 03:06:32 -08:00
8d515d407c
Migrate SConfig::m_is_mios to System.
2024-01-30 03:45:17 +01:00
12fe5550d2
Externals/hidapi: Convert to submodule
...
This also updates to 0.14.0 (d3013f0af3
2024-01-30 01:35:39 +01:00
e1ec47b504
Merge pull request #12223 from luc-git/comments
...
Update comments RenderWidget.cpp
2024-01-30 01:25:57 +01:00
d124fcbb0d
DolphinQt/RenderWidget: Add comments for SetCursorLocked() on Linux.
...
Co-authored-by: Admiral H. Curtiss <pikachu025@gmail.com>
2024-01-30 01:06:30 +01:00
1e2fb41d0f
Merge pull request #12538 from LillyJadeKatrin/retroachievements-bugfix
...
Reverse endianness of achievement memory peeks
2024-01-30 00:52:18 +01:00
fd99a5db9a
Reverse endianness of achievement memory peeks
...
rcheevos expects these multi-byte peeks to have the opposite endianness so they need to be swapped before rcheevos gets them.
2024-01-29 11:55:49 -05:00
8482a50154
Merge pull request #12530 from iwubcode/custom_shaders_compilation_fixes
...
VideoCommon: fix some issues when compiling custom shaders
2024-01-28 14:30:37 +01:00
4843705061
Merge pull request #12534 from iwubcode/custom-pipeline-refactor
...
VideoCommon: refactor the custom pipeline logic to be reusable
2024-01-28 14:28:23 +01:00
c9715e7e7d
Merge pull request #12535 from iwubcode/vertexmanager_draw_refactor
...
VideoCommon: refactor drawing into its own function
2024-01-28 14:27:41 +01:00
0405b4dcc2
Merge pull request #12536 from LillyJadeKatrin/retroachievements-bugfix
...
Removed post data from Achievement request logs
2024-01-28 14:26:09 +01:00
f25bdda728
Removed post data from Achievement request logs
...
post_data included passwords and API keys in plaintext so continuing to include it in logs is a security liability.
2024-01-27 18:50:27 -05:00
990303a028
Merge pull request #12519 from lioncash/leak
...
PostProcessing: Don't potentially leak memory in BlitFromTexture()
2024-01-27 22:29:45 +01:00
c34b3ae390
VideoCommon: refactor drawing into its own function
2024-01-27 14:45:34 -06:00
3e3967ff94
VideoCommon: refactor the custom pipeline logic in the graphics mod action into a separate class, so it is reusable
2024-01-27 00:12:49 -06:00
e740e32562
Merge pull request #12522 from lioncash/ppcanalyst
...
PPCAnalyst: Merge duplicate expression in ReorderInstructionsCore()
2024-01-26 20:29:16 +01:00
b0491c2ce8
Merge pull request #12529 from iwubcode/math_determinant
...
Common: add determinant functions to Matrix33 and Matrix44
2024-01-26 19:13:38 +01:00
Lioncash