ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Interpreter: Fix subfic carry calculation 

This was accidentally using the instruction's output instead of the
instruction's input when the input and output registers were the same.
This commit is contained in:
JosJuice 2024-08-31 17:24:55 +02:00
parent 38b189e13d
commit ff75cc80aa
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Core/Core/PowerPC/Interpreter/Interpreter_Integer.cpp
View File

@ -141,10 +141,10 @@ void Interpreter::oris(Interpreter& interpreter, UGeckoInstruction inst)
void Interpreter::subfic(Interpreter& interpreter, UGeckoInstruction inst) void Interpreter::subfic(Interpreter& interpreter, UGeckoInstruction inst)
{ {
auto& ppc_state = interpreter.m_ppc_state; auto& ppc_state = interpreter.m_ppc_state;
const s32 a = s32(ppc_state.gpr[inst.RA]);
const s32 immediate = inst.SIMM_16; const s32 immediate = inst.SIMM_16;
ppc_state.gpr[inst.RD] = u32(immediate - s32(ppc_state.gpr[inst.RA])); ppc_state.gpr[inst.RD] = u32(immediate - a);
ppc_state.SetCarry((ppc_state.gpr[inst.RA] == 0) || ppc_state.SetCarry((a == 0) || (Helper_Carry(0 - u32(a), u32(immediate))));
(Helper_Carry(0 - ppc_state.gpr[inst.RA], u32(immediate))));
} }
void Interpreter::twi(Interpreter& interpreter, UGeckoInstruction inst) void Interpreter::twi(Interpreter& interpreter, UGeckoInstruction inst)